Simon Kuenzer [Mon, 28 Aug 2023 13:14:54 +0000 (15:14 +0200)]
lib/vfscore: Embedded initrd
This commit introduces the ability to embed a CPIO initrd in a unikernel
image. This can be useful to hard link an initrd content to an
unikernel. An additionally provided initrd can then be used freely with the
fstab function.
Checkpatch-Ignore: AVOID_EXTERNS Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1070
Simon Kuenzer [Mon, 28 Aug 2023 13:12:34 +0000 (15:12 +0200)]
lib/vfscore: Support initrds with `LIBVFSCORE_ROOTFS_CUSTOM`
Commit 24be5b01a7da ("lib/vfscore: Implement individual volume automounting")
disabled the ability to manually specify mounting of an initrd with
`LIBVFSCORE_ROOTFS_CUSTOM`. Initrd support depends on `LIBUKCPIO` and
`LIBRAMFS`. This commit brings back this feature.
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1070
Simon Kuenzer [Mon, 28 Aug 2023 20:20:39 +0000 (22:20 +0200)]
build: Compile dependencies for source files (`*_CDEPS`)
For each source file, additional dependencies that trigger recompilation
can be specified in `Makefile.uk` with `*_CDEPS`:
```
<LIBNAME>_<SOURCENAME>[_<VARIANT>]_CDEPS += <dependency>
<LIBNAME>_<SOURCENAME>[_<VARIANT>]_CDEPS-y += <dependency>
```
Please note that because of the need to remove quotes from filenames,
`qstrip` is called and therefore the CDEPS variable cannot be expanded
with a second expansion (`$$()`).
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1070
Simon Kuenzer [Mon, 28 Aug 2023 20:19:48 +0000 (22:19 +0200)]
build: Restructure common dependencies for buildrule_*
Restructures the build rules to put common dependencies in a single place.
The advantage is that these dependencies are now automatically applied for
externally defined build rules.
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1070
Marco Schlumpp [Mon, 20 Feb 2023 13:57:00 +0000 (14:57 +0100)]
plat/virtio: Implement support for event index notification suppression
This allows the drivers/device to specify the other side should
send a notification. This is required for firecracker which does not
support the original notification suppression flag.
Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Andrei Tatar <andrei@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1089
Tianyi Liu [Mon, 31 Jul 2023 05:50:16 +0000 (13:50 +0800)]
arch/arm64: Support AArch64 binary syscalls
An interrupt handler is provided to redirect the interrupts
generated by binary syscalls to the `syscall-shim` layer.
Signed-off-by: Tianyi Liu <i.pear@outlook.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Simon Kuenzer <simon.kuenzer@unikraft.io>
GitHub-Closes: #1009
plat/common/arm: Check for offline GICC during ACPI MP enumeration
When we probe for available, valid GICC's, we only look for those
that are already online and initialized, totally forgetting about
those that are usable but offline. Therefore, check for powered off
GICC's as well, since, during probe, we re-initialize GICC's anyway.
plat/common/acpi: Fix `VGIC IRQ MODE` flag bitfield of `GICC`
The bitfield `ACPI_MADT_GICC_FLAGS_VGIC_IRQ_MODE` of `GICC` had
the wrong value: it may be the 3rd bit from right to left, but its
corresponding value is 4 (1 << 2) not 3.
Marc Rittinghaus [Tue, 15 Feb 2022 16:37:51 +0000 (17:37 +0100)]
drivers/virtio: Fix unhandled IRQ
It may happen that depending on timing there is no new data in the
virtio queue, however, an IRQ is still pending. When this pending IRQ
is handled, the driver reports back that it did not handle the request
although in fact resetting the IRQ signal bit in the virtio device is
enough to acknowlegde that an interrupt for the device has been
received and handled (albeit without having to do any additional
work). This will lead to a false Unhandled IRQ error message on
the console. This commit is a first dirty hack to just always
acknowledge IRQs if the status bit is set, thereby avoiding the
error message.
Checkpatch-Ignore: LONG_LINE Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu> Signed-off-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Andrei Topala <topala.andrei@gmail.com> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1115
driver/virtio/mmio: Make config_get return value consistent with PCI
Update the return value of virtio-mmio ops->config_get to return zero
on success rather like the number of bytes read, to align with virtio-pci.
This allows consistent error handling from device driver side.
Signed-off-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Andrei Topala <topala.andrei@gmail.com> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1115
Due to virtio using separate data and control paths, it is normal for
the queue to be observed as empty if the interrupt arrives before the
write can be observed by the driver. Downgrade the severity of the log
message to `debug`.
Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu> Signed-off-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Andrei Topala <topala.andrei@gmail.com> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1115
Sergiu Moga [Fri, 6 Oct 2023 09:27:04 +0000 (12:27 +0300)]
plat: Increase debug messages of the memregion coalescing function
Add more debugging messages to `ukplat_memregion_list_coalesce` to help
in finding inconsistencies as well as misbehaving memory region maps.
Furthermore, replace returns of error codes with `UK_ASSERT` and, thus,
change `ukplat_memregion_list_coalesce`'s signature to return nothing
as well as its callers' site accordingly.
Sergiu Moga [Fri, 6 Oct 2023 09:25:47 +0000 (12:25 +0300)]
plat/common/memory: Add memregion descriptor print function
Implement a basic printing function for memory regions.
`ukplat_memregion_print_desc`'s implementation will be conditioned
by whether `CONFIG_LIBUKDEBUG_PRINTD` is enabled or not.
plat/common: Do not insert left region empty leftover on overlap
Consider the following case:
|-----------|----------|---------------|
| | | |
|-----------|----------|---------------|
ML start MR start MR end ML end
In the current state, we insert the (ML end - MR end) region regardless
of its length. If it is equal to 0, we end up inserting an empty memory
region. Thus, do not do this insertion if (ML end - MR end) == 0.
Sergiu Moga [Sat, 19 Aug 2023 15:56:01 +0000 (18:56 +0300)]
plat/common: Error out if free regions not aligned for paging init
If the early code did everything right when setting up the memory
regions, then no free memory region should be misaligned by this
point. Otherwise, something bad happened so throw an exception.
Sergiu Moga [Sat, 19 Aug 2023 10:35:23 +0000 (13:35 +0300)]
lib/ukboot: Ensure page-aligned mem regions are added to allocator
If paging is disabled, ensure compatibility with memory allocators
such as TLSF, by only adding page-aligned free memory regions to the
memory allocator pools. Throw an exception otherwise.
Sergiu Moga [Mon, 21 Aug 2023 07:28:49 +0000 (10:28 +0300)]
plat: Make memory region coalescing function handle misalignments
In order to preserve alignment among memory region descriptors, we
would strive to align every inserted memory region. However, this
would also rely on the boot protocol itself to report initial aligned
memory regions, which seems not be the case for some boot protocols
(e.g. cmdline may not be aligned in `Multiboot1`, `initrd` start
address may not be aligned in Linux Boot Protocol).
Therefore, write a single, centralized solution, inside the memory
region coalescing function and make it handle misalignment cases
as well to cope with misbehaving boot protocols. To guarantee
alignment, take each memory region, align it to both ends and
then resolve overlappings. Just like before, free memory regions
are trimmed in favor of other types of memory regions. We know
free memory regions will always be aligned because resolving
conflicts between aligned memory region descriptors will always
yield aligned memory regions.
To preserve original sizes of user allocated memory region descriptors,
in case a deletion is not detected, restore the start address and
length of such region and make sure that the `vbase` field stays updated
with new values of `pbase`.
Finally, now that we offload alignments to the newly improved coalescing
method, remove manual, hardcoded alignments from early boot glue code.
If everything goes as planned and is implemented in a manner where
expectations are met, these alignments should not be needed as they
are transparently ensured by the coalescing method as well as the
paging initialization.
Sergiu Moga [Sat, 19 Aug 2023 15:33:34 +0000 (18:33 +0300)]
plat/common: Preserve original size of allocated memory regions
Previously, `ukplat_memregion_alloc()` would allow one to dynamically
allocate based on available free memory regions a certain memory region
of a specific type and with specific flags and whose size will be the
page-aligned size of the desired size.
A user may want however to fetch some memory regions and know the
actual, intended size. To achieve this, make it so that the allocated
memory region has the original size on the surface, but the actual
allocation is done by splitting a page-aligned chunk to avoid
misalignments.
This leads to the same amount of memory fragmentation as before,
but with the improvement that the user of the API will have access to
the actual size of the data the memory region was allocated for.
Luckily, the paging initialization code is written in such a way that
it aligns every memory region before mapping/unmapping.
Sergiu Moga [Thu, 31 Aug 2023 18:29:48 +0000 (21:29 +0300)]
support/scripts: Use elf64_to_32.py for the multiboot header
Since `multiboot` demands that its corresponding header be placed in the
first 8192 bytes and `GRUB` for whatever reason adds another restriction
requesting that the ELF Program Headers also have to be found in this
range (see GRUB commit 9a5c1ad), offload the effort of building the
Multiboot header from the GAS directive defined header of `multiboot.S`
to `elf64_to_32.py`.
This will offer us more flexiblity and relieve us of the effort of
having anything ELF32 related inside the core codebase.
Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1079
Sergiu Moga [Thu, 31 Aug 2023 18:29:48 +0000 (21:29 +0300)]
support/scripts: Rename `elf64_to_32.py` to `multiboot.py`
Now that we use `elf64_to_32.py` for building the `multiboot` header as
well and `elf64_to_32.py` is only used for `multiboot` builds, rename
the script accordingly, to reflect the fact the sole reason this script
exists is to cope with the demands of this ancient boot protocol.
Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1079
Stefan Jumarea [Wed, 20 Sep 2023 20:32:10 +0000 (23:32 +0300)]
lib/9pfs: Return ENOTTY on terminal ioctl calls
Some applications (e.g. python) will use `ioctl()` calls to check if an
interactive interpretor should be started or if a file should be read.
`9pfs` should respond to all terminal-related calls with an `ENOTTY`
error, so applications know that they are not running in an interactive
environment.
In order to detect the ioctl request type, add a new macro,
`IOCTL_CMD_ISTYPE(cmd, type)`, which will check the corresponding bytes
from the request number (an enhanced version of the Linux `_IOC_TYPE`).
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #1098
Stefan Jumarea [Fri, 15 Sep 2023 20:02:51 +0000 (23:02 +0300)]
lib/9pfs: Return ENOTSUP on ioctl requests
Currently `9pfs` returns 0 for any `ioctl` request (except for
`TIOCGWINSZ`), which leads to multiple cases of files being interpreted
as terminals. You can see this problem when running python scripts,
since python uses `ioctl` calls to check if it should open up the
interactive interpretor or execute a script.
Same thing could happen for other applications that rely on `ioctl`
operations being properly executed, so the best way to go would be
return `ENOTSUP` (as is used to happen before commit 28d0edf).
If the `ioctl` call always return `ENOTSUP`, the Ruby binary
compatibility application will fail, since it tries to set O_ASYNC and
breaks on error, even if it does not directly depends on that, so for
now add a special case for that.
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #1098
Stefan Jumarea [Tue, 22 Aug 2023 17:35:16 +0000 (20:35 +0300)]
Makefile: Fix build verbosity for V=0
When setting `V=0`, we expect the verbosity level to be reduced, and
only the build output to be printed, not the build commands.
Set `Q = @` by default, in case `V != 0` is set, set `Q` appropriately.
Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
GitHub-Fixes: #676 Reviewed-by: Razvan Virtan <virtanrazvan@gmail.com> Reviewed-by: Robert Kuban <robert.kuban@opensynergy.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1066
plat/common/x86: Separate `start16` relocations from `ukreloc`
Since `start16` related symbols have a relocation mechanism similar,
but entirely independent from `ukreloc`, rename all such symbols,
macro's and their uses so that they do not contain the `uk_reloc` or
the `UKRELOC` substrings.
Sergiu Moga [Wed, 30 Aug 2023 17:54:07 +0000 (20:54 +0300)]
support/scripts: `checkpatch` `WARN` on commit subject > 70 chars
Although `checkpatch.pl` checks for commit message lines to not be
longer than `75` characters, in the case of `Github`'s UI, a commit
subject longer than `70` character results in its line overflowing
into the next.
E.g.
```
[Selector]/[Component]: Lorem ipsum dolor sit amet, consectetuer adipiscin
```
becomes
```
[Selector]/[Component]: Lorem ipsum dolor sit amet, consectetuer adip...
...iscin
```
Since this is not aesthetically pleasing, enforce a character limit for
commit message subjects to not be longer than `70` characters.
Marco Schlumpp [Tue, 12 Sep 2023 11:21:01 +0000 (13:21 +0200)]
lib/uklock: Remove the rwlock_{upgrade,downgrade} functions
In the current form they impose very strong synchronization requirements,
making it impossible to implement a more efficient read-write lock design.
Most rwlocks sidestep this by either using a weaker `try_upgrade` variant
or having a separate `lock_upgradable` function (allowing multiple readers
but only one upgradable lock/writer lock).
This removes these two functions for now to prevent new code relying on
these functions. This change is breaking because it already was part of the
previous release.
Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Andrei Tatar <andrei@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1090
Tianyi Liu [Fri, 15 Sep 2023 18:02:41 +0000 (02:02 +0800)]
arch/*: Add an non-aligned version for stack-pushing
For AArch64, `ukarch_rctx_stackpush` may add padding to make sure
the `sp` register is aligned to 16 bytes. But there're also some
use cases where alignment is not allowed. In such cases, the newly
added `ukarch_rctx_stackpush_packed` and `ukarch_rstack_push_packed`
will be useful.
Signed-off-by: Tianyi Liu <i.pear@outlook.com> Reviewed-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Andrei Tatar <andrei@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1096
Andrei Tatar [Thu, 14 Sep 2023 08:58:45 +0000 (11:58 +0300)]
lib/vfscore: Fix pipe error codes
This change fixes incorrect return of error codes in the pipe module of
vfscore. Specifically:
- Return positive error codes from internal functions; syscall handlers
expect positive errors and will negate them as required
- Do not set errno, rather return the error code
- Correctly return EINVAL when attempting to open a pipe with O_DIRECT,
as we do not support packet mode pipes, and calling code needs to be
made aware of this
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1093
The futimes and lutimes functions are defined with a `struct timeval [2]`
argument. They are however instantiated with a pointer. This causes a build
warning.
Change the instantiation from pointer to array. This removes the build warning.
Signed-off-by: Tiago Andre Goncalves Oliveira <t.g.oliveira@ua.pt> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1099
Andrei Tatar [Mon, 28 Aug 2023 19:31:17 +0000 (21:31 +0200)]
lib/ramfs: Fix UAF bug when deleting open file
Previously ramfs would eagerly free filesystem nodes when deleting a
file regardless whether the file is open, leading to a possible
use-after-free bug if the open file is later used.
This change fixes this issue by marking nodes as deleted after they have
been removed from the filesystem, then only releasing resources lazily
once all open references have been garbage-collected.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Delia Pavel <delia_maria.pavel@stud.acs.upb.ro> Reviewed-by: Radu Nichita <radunichita99@gmail.com>
GitHub-Closes: #1075
Andrei Tatar [Mon, 28 Aug 2023 19:13:49 +0000 (21:13 +0200)]
lib/vfscore: Fix potential vfscore_file mem leak
Previously if `fdalloc` failed to allocate a file descriptor, the
function would exit without decrementing the reference count on the
vfscore_file object, leading to a potential memory leak.
This change reorders operations to prevent this scenario.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Delia Pavel <delia_maria.pavel@stud.acs.upb.ro> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1074
Simon Kuenzer [Fri, 8 Sep 2023 17:37:46 +0000 (19:37 +0200)]
build: Always save architecture with savedefconfig
With `savedefconfig`, KConfig creates a file that contains only options
that are different from the default selection. Because the build system
automatically detects the host architecture and sets the default
architecture to this detected architecture, the architecture is never
part of the defconfig file if the architecture in the configuration
matches the host architecture. This becomes problematic as soon as such
a file is loaded on a build environment that has a different host
architecture: The configuration can fail because of architectural
configuration differences.
This commit ensures that the configured architecture is always stored
in the defconfig file. The `savedefconfig` target appends the configured
architecture to the file if the architectures between host and config
match.
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikrat.io>
GitHub-Closes: #1084
Simon Kuenzer [Fri, 8 Sep 2023 21:30:11 +0000 (23:30 +0200)]
build: Forward host architecture from build system to KConfig
Commit c11dceaa9698 ("kconfig: Determine the default arch from CC")
introduced the automatic selection of a default target architecture by
querying and parsing the default compiler's target machine. Because the
detection breaks across GCC output versions, this commit forwards the host
architecture already detected by the main Makefile to the KConfig
system. This way, KConfig will be in sync with what the Makefile system has
detected.
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikrat.io>
GitHub-Closes: #1084
Simon Kuenzer [Fri, 8 Sep 2023 17:37:18 +0000 (19:37 +0200)]
build: Do not check for updates with `savedefconfig`
The `savedefconfig` target is not saving a new configuration (`.config`)
but it derives a minimal configuration from the current
configuration. Because of this, it is not necessary to check for
updates to the configuration.
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikrat.io>
GitHub-Closes: #1084
Andrei Tatar [Wed, 16 Aug 2023 15:10:50 +0000 (17:10 +0200)]
lib/ukcpio: Preserve timestamp of extracted files
Previously ukcpio did not honor the `mtime` field of cpio sections,
leaving extracted files timestamped with the extraction time.
This change implements setting the timestamps for regular files.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Adina-Maria Vaman <adinamariav22@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikrat.io>
GitHub-Closes: #1071
Andrei Tatar [Wed, 16 Aug 2023 14:24:50 +0000 (16:24 +0200)]
lib/ukcpio: Remove use of malloc & free
This change removes the use of heap memory for computing the extraction
path, eliminating a call to malloc & free for every cpio section,
leaving ukcpio to use only stack memory.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Adina-Maria Vaman <adinamariav22@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikrat.io>
GitHub-Closes: #1071
Andrei Tatar [Wed, 16 Aug 2023 14:01:36 +0000 (16:01 +0200)]
lib/ukcpio: Replace file libcalls with syscalls
This change replaces calls to open, close, write, chmod, and mkdir with
their raw Unikraft syscall equivalents, preventing a call into
potentially non-unikraft code, as well as eliminating the use of errno.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Adina-Maria Vaman <adinamariav22@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikrat.io>
GitHub-Closes: #1071
Andrei Tatar [Mon, 28 Aug 2023 19:25:05 +0000 (21:25 +0200)]
lib/ukmmap: Fix wrong return of NULL
Previously ukmmap's `mmap()` would return NULL for unimplemented cases.
However, no calling code expects this, and will wrongly try to use the
returned buffer.
This change corrects this oversight and returns MAP_FAILED in all cases
of error.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Delia Pavel <delia_maria.pavel@stud.acs.upb.ro> Reviewed-by: Andra Paraschiv <andra@unikraft.org> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1073
Simon Kuenzer [Fri, 22 Sep 2023 14:52:39 +0000 (16:52 +0200)]
scripts: Use GNU version of coreutils on Darwin
This commit changes the scripts under `support/scripts` and
`support/build` so that they use the GNU versions of the following
commands on Darwin:
```
readlink, dirname, grep
```
As soon as Darwin is detected as host environment, the scripts use
the following commands instead:
```
greadlink, gdirname, ggrep
```
These tools are typically installed with HomeBrew
(`brew install coreutils`).
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Jakub Ciolek <jakub.ciolek@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1109
Simon Kuenzer [Fri, 22 Sep 2023 20:13:56 +0000 (22:13 +0200)]
build: Provide command variables for `readlink` and `dirname`
For future references this commit adds command variables for `readlink`
and `dirname`. On Darwin these variables point to the GNU versions of
the commands. They are typically installed with HomeBrew
(`brew install coreutils`) and prefixed with a `g`:
`greadlink`, `gdirename`.
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Jakub Ciolek <jakub.ciolek@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1109
Simon Kuenzer [Fri, 22 Sep 2023 15:00:17 +0000 (17:00 +0200)]
build: Use ggrep on Darwin (MacOS)
The build system depends on the GNU version of `grep`. Since this is
typically installed with `ggrep` on Darwin environments with HomeBrew
(`brew install coreutils`), we call `ggrep` in such a case.
Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Jakub Ciolek <jakub.ciolek@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1109
Simon Kuenzer [Wed, 30 Aug 2023 21:38:19 +0000 (23:38 +0200)]
support/scripts: mkcpio: Support Darwin (MacOS) environments
The standard `cpio` tool available under Darwin is the equivalent of the
`bsdcpio` tool available under Linux. At the beginning of the script we
detect the host environment and use `bsdcpio` or `cpio` accordingly.
Andrei Tatar [Fri, 15 Sep 2023 12:52:19 +0000 (14:52 +0200)]
build: Add target to print unikernel LoC stats
This change adds the `print-loc` Makefile target which (fairly hackishly)
computes and prints statistics about the number of lines of code that
make it into a built unikernel image. It is not intended as an end-user
metric and thus does not aim for any particular level of accuracy or
edge-case handling, rather it is a fun little dev tool that allows
rough comparisons of the level of "bloat" between unikernels.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1108
Marco Schlumpp [Wed, 13 Sep 2023 09:34:17 +0000 (11:34 +0200)]
build: Forward YACC/LEX to kconfig make invocation
KConfig relies on GNU bison and does not work with the classical yacc.
While most Linux distributions prefer bison and add a symlink for yacc,
there are distributions that do not this (Fedora). They seem to actually
use the original Berkeley yacc to provide `yacc`.
Instead of using the default `yacc` for `YACC` in make explicitly forward
our preference for `bison` to the kconfig Makefile.
Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1092
Andrei Tatar [Tue, 22 Aug 2023 13:43:05 +0000 (15:43 +0200)]
lib/vfscore: Replace dup2 syscalls with dup3
vfscore contained internal calls to the dup2 syscall, which is not
universally provided on all architectures, notably absent on AArch64.
This change replaces calls to dup2 with dup3 which is more universal.
Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Ioan-Teodor Teugea <ioan_teodor.teugea@stud.acs.upb.ro> Reviewed-by: Andra Paraschiv <andra@unikraft.org> Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1069
Using Musl and the dirent64 structure causes build warnings. This is
because certain source code files do not define _GNU_SOURCE. Fix build
warnings by defining _GNU_SOURCE in the required source code files.
Signed-off-by: Tiago Andre Goncalves Oliveira <t.g.oliveira@ua.pt> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #1097
Robert Kuban [Tue, 5 Sep 2023 14:39:58 +0000 (16:39 +0200)]
Makefile: Fix support for external platforms
Set `KCONFIG_EPLAT_DIRS` to the list of external platforms `$(P)` instead
of `$(E)`, which is not defined in this context.
With the change, the `config-submenu.sh` script will pickup the `Config.uk`
of an external platform as expected.
Signed-off-by: Robert Kuban <robert.kuban@opensynergy.com> Reviewed-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #1082
plat/kvm: Update `kvm/Config.uk` and `kvm/Makefile.uk`
Remove VIRTIO from `kvm/Makefile.uk` and
update VIRTIO drivers on KVM:
* Enable the VIRTIO PCI driver on KVM QEMU VMMs.
* Enable the VIRTIO MMIO driver on all KVM VMMs for arm64.
* Enable the VIRTIO BLK and NET drivers for both
KVM QEMU and Firecracker.
* Enable the VIRTIO 9P driver for when `LIBUK9P`
is selected.
* Correct indentation
lib/9pfs: Add check for `NULL` `data` in `uk_9pfs_parse_options`
The `mount` system call may actually allow ignoring the `data`
argument depending on the usecase. Therefore allow `data` to be
`NULL` by adding a check in `uk_9pfs_parse_options`.
Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #1086
projects / unikraft / unikraft.git / log