]> xenbits.xensource.com Git - libvirt.git/log
libvirt.git
16 years agoAdd an initial User Mode Linux Driver
Daniel P. Berrange [Wed, 19 Nov 2008 16:58:23 +0000 (16:58 +0000)]
Add an initial User Mode Linux Driver

16 years agoAdd a virFreeCallback to event loop APIs
Daniel P. Berrange [Wed, 19 Nov 2008 16:24:01 +0000 (16:24 +0000)]
Add a virFreeCallback to event loop APIs

16 years agoChange public API for virEventAddHandle to allow multiple registrations per FD
Daniel P. Berrange [Wed, 19 Nov 2008 16:19:36 +0000 (16:19 +0000)]
Change public API for virEventAddHandle to allow multiple registrations per FD

16 years agoAdd a virFreeCallback to virDomainEventRegister (from David Lively)
Daniel P. Berrange [Wed, 19 Nov 2008 15:25:24 +0000 (15:25 +0000)]
Add a virFreeCallback to virDomainEventRegister (from David Lively)

16 years agoFix windows build & build without QEMU driver
Daniel P. Berrange [Tue, 18 Nov 2008 12:46:13 +0000 (12:46 +0000)]
Fix windows build & build without QEMU driver

16 years agoAdd QEMU driver events for defined/undefined config files
Daniel P. Berrange [Mon, 17 Nov 2008 16:52:32 +0000 (16:52 +0000)]
Add QEMU driver events for defined/undefined config files

16 years agoAdd domain events detail information
Daniel P. Berrange [Mon, 17 Nov 2008 16:43:00 +0000 (16:43 +0000)]
Add domain events detail information

16 years agoLink QEMU, LXC, network and storage drivers directly into libvirtd
Daniel P. Berrange [Mon, 17 Nov 2008 12:18:18 +0000 (12:18 +0000)]
Link QEMU, LXC, network and storage drivers directly into libvirtd

16 years agoPush URI probing logic down into individual drivers
Daniel P. Berrange [Mon, 17 Nov 2008 11:44:51 +0000 (11:44 +0000)]
Push URI probing logic down into individual drivers

16 years agoRefactor storage backends to avoid dependancy from config parser to implementation
Daniel P. Berrange [Mon, 17 Nov 2008 11:19:33 +0000 (11:19 +0000)]
Refactor storage backends to avoid dependancy from config parser to implementation

16 years agoUse a versioned linker script
Daniel P. Berrange [Mon, 17 Nov 2008 11:03:25 +0000 (11:03 +0000)]
Use a versioned linker script

16 years agoBuild drivers as libtool convenience libs
Daniel P. Berrange [Mon, 17 Nov 2008 10:43:30 +0000 (10:43 +0000)]
Build drivers as libtool convenience libs

16 years agoFix domain events python thread safety & incorrect enum generation
Daniel P. Berrange [Mon, 17 Nov 2008 10:26:09 +0000 (10:26 +0000)]
Fix domain events python thread safety & incorrect enum generation

16 years agoFix updating of openvz config file params
Daniel P. Berrange [Mon, 17 Nov 2008 09:55:59 +0000 (09:55 +0000)]
Fix updating of openvz config file params

16 years agoUse different separator for lvs command to unbreak parsing for encrypted devs.
Cole Robinson [Fri, 14 Nov 2008 16:10:47 +0000 (16:10 +0000)]
Use different separator for lvs command to unbreak parsing for encrypted devs.

16 years agoavoid format string warnings
Jim Meyering [Fri, 14 Nov 2008 14:19:37 +0000 (14:19 +0000)]
avoid format string warnings

* src/openvz_driver.c (ADD_ARG_LIT): Add "%s" arg before _(...).
* src/qemu_driver.c (PCI_ATTACH_OK_MSG): Likewise.
* src/util.c (virExec, virRun): Likewise.

16 years agoKVM/QEmu migration support
Daniel Veillard [Fri, 14 Nov 2008 08:42:47 +0000 (08:42 +0000)]
KVM/QEmu migration support
* qemud/remote.c qemud/remote_dispatch_localvars.h
  qemud/remote_dispatch_proc_switch.h qemud/remote_dispatch_prototypes.h
  qemud/remote_protocol.c qemud/remote_protocol.h
  qemud/remote_protocol.x src/driver.h src/libvirt.c
  src/libvirt_internal.h src/libvirt_sym.version src/lxc_driver.c
  src/openvz_driver.c src/qemu_conf.h src/qemu_driver.c
  src/remote_internal.c src/test.c src/virsh.c: large patch to
  add migration support for KVM/QEmu, based on the work of Rich Jones
  and Chris Lalancette. This introduce a new version of the prepare
  and finish steps of the migration, so changes the driver API and
  a lot of code.
Daniel

16 years agoAdd bridged network to openvz driver & add some openvz docs
Daniel P. Berrange [Wed, 12 Nov 2008 16:35:47 +0000 (16:35 +0000)]
Add bridged network to openvz driver & add some openvz docs

16 years agoRevert previous storage patch which broke test driver
Daniel P. Berrange [Wed, 12 Nov 2008 16:28:27 +0000 (16:28 +0000)]
Revert previous storage patch which broke test driver

16 years agoRe-arrange storage backend registration
Daniel P. Berrange [Tue, 11 Nov 2008 15:52:16 +0000 (15:52 +0000)]
Re-arrange storage backend registration

16 years agoSupport OpenVZ filesystem template config in XML dump
Daniel P. Berrange [Mon, 10 Nov 2008 12:08:19 +0000 (12:08 +0000)]
Support OpenVZ filesystem template config in XML dump

16 years agotweak lstat.c to avoid mingw link failure
Jim Meyering [Fri, 7 Nov 2008 16:44:38 +0000 (16:44 +0000)]
tweak lstat.c to avoid mingw link failure

* gnulib/lib/lstat.c: Include <sys/stat.h> *before* the use of stat in
orig_stat.  Otherwise, on mingw (which lacks lstat), any program using
the lstat module would not get the redefinition-to-stat provided by
gnulib's sys/stat.h.  Reported by Daniel P. Berrange.

16 years agomark a few diagnostics for translation
Jim Meyering [Fri, 7 Nov 2008 16:43:58 +0000 (16:43 +0000)]
mark a few diagnostics for translation

* src/lxc_conf.c (lxcLoadDriverConfig): Mark a diagnostic.
* src/lxc_driver.c (lxcDomainStart): Likewise.
* po/POTFILES.in: Add src/lxc_conf.c.
* Makefile.maint (msg_gen_function): Add virReportErrorHelper
and lxcError.

16 years agoalways compile iptables.c
Jim Meyering [Fri, 7 Nov 2008 16:43:23 +0000 (16:43 +0000)]
always compile iptables.c

Avoid a build error when configuring --without-xen --without-qemu.
* src/iptables.c [WITH_QEMU]: Don't #ifdef-out.
* src/iptables.h [WITH_QEMU]: Don't #ifdef-out.
* src/util.c (virRun) [__MINGW32__]: Define a stub that always fails.

16 years agoadd new logging module, and move existing definitions there
Daniel Veillard [Thu, 6 Nov 2008 16:36:07 +0000 (16:36 +0000)]
add new logging module, and move existing definitions there
* src/logging.c src/logging.h proxy/Makefile.am proxy/libvirt_proxy.c
  src/Makefile.am src/cgroup.c src/datatypes.c src/domain_event.c
  src/internal.h src/libvirt.c src/lxc_container.c src/lxc_controller.c
  src/lxc_driver.c src/proxy_internal.c src/qemu_driver.c
  src/remote_internal.c src/storage_backend_disk.c src/util.c
  src/veth.c src/xen_internal.c src/xen_unified.c src/xend_internal.c:
  add new logging module, and move existing definitions there
Daniel

16 years agoLog stdout and stderr in virRun
Cole Robinson [Wed, 5 Nov 2008 18:57:42 +0000 (18:57 +0000)]
Log stdout and stderr in virRun

16 years agoLog the argv passed to virExec and virRun
Cole Robinson [Wed, 5 Nov 2008 18:41:07 +0000 (18:41 +0000)]
Log the argv passed to virExec and virRun

16 years agoMove local argvToString to virArgvToString in util.
Cole Robinson [Wed, 5 Nov 2008 18:22:10 +0000 (18:22 +0000)]
Move local argvToString to virArgvToString in util.

16 years agoplug two leaks and fix a diagnostic
Jim Meyering [Wed, 5 Nov 2008 14:24:21 +0000 (14:24 +0000)]
plug two leaks and fix a diagnostic

* src/qemu_conf.c (qemudLoadDriverConfig): Don't leak ->vncListen.
Fix an erroneous copy-and-pasted diagnostic.
* src/qemu_driver.c (qemudShutdown): Don't leak another ->vncListen.

16 years agoCall vgscan before attempting to scan logical volumes. This makes sure we've
Chris Lalancette [Wed, 5 Nov 2008 11:41:43 +0000 (11:41 +0000)]
Call vgscan before attempting to scan logical volumes.  This makes sure we've
"touched" any logical volumes, so they appear in the subsequent "pvs" call.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoMove WITH_XXX driver feature flags into config.h instead of direct compiler/linker...
Daniel P. Berrange [Tue, 4 Nov 2008 23:37:23 +0000 (23:37 +0000)]
Move WITH_XXX driver feature flags into config.h instead of direct compiler/linker args

16 years agoMove domain events helpers into dedicated file
Daniel P. Berrange [Tue, 4 Nov 2008 23:33:57 +0000 (23:33 +0000)]
Move domain events helpers into dedicated file

16 years agoMove some API declarations out of internal.h & hash.c into dedicated files
Daniel P. Berrange [Tue, 4 Nov 2008 23:22:06 +0000 (23:22 +0000)]
Move some API declarations out of internal.h & hash.c into dedicated files

16 years agoRemove unused internal virStateSigDispatcher() API
Daniel P. Berrange [Tue, 4 Nov 2008 22:55:51 +0000 (22:55 +0000)]
Remove unused internal virStateSigDispatcher() API

16 years agoMove internal error APIs into virterror_internal.h & drop leading __ prefix
Daniel P. Berrange [Tue, 4 Nov 2008 22:30:33 +0000 (22:30 +0000)]
Move internal error APIs into virterror_internal.h & drop leading __ prefix

16 years agoAdd support for -uuid and -domid args to QEMU
Daniel P. Berrange [Tue, 4 Nov 2008 22:15:30 +0000 (22:15 +0000)]
Add support for -uuid and -domid args to QEMU

16 years agoRemove use of virStringList in favour of strongly typed APIs
Daniel P. Berrange [Tue, 4 Nov 2008 21:54:21 +0000 (21:54 +0000)]
Remove use of virStringList in favour of strongly typed APIs

16 years agodon't print an uninitialized integer in a diagnostic
Jim Meyering [Tue, 4 Nov 2008 15:02:36 +0000 (15:02 +0000)]
don't print an uninitialized integer in a diagnostic

* src/virterror.c (__virErrorMsg) [VIR_ERR_XEN_CALL]:
Use a format with only one % directive.

16 years agoadd a test for today's fix
Jim Meyering [Tue, 4 Nov 2008 14:55:30 +0000 (14:55 +0000)]
add a test for today's fix

* tests/cpuset: New script.  Test for today's fix.
* tests/Makefile.am (test_scripts): Add cpuset.

16 years ago* AUTHORS: added Guido Günther as new commiter, Dan Smith was missing too
Daniel Veillard [Mon, 3 Nov 2008 16:14:04 +0000 (16:14 +0000)]
* AUTHORS: added Guido Günther as new commiter, Dan Smith was missing too
daniel

16 years ago* src/qemu_conf.c: switch off cache if disk is shared and not read-only
Daniel Veillard [Mon, 3 Nov 2008 15:58:02 +0000 (15:58 +0000)]
* src/qemu_conf.c: switch off cache if disk is shared and not read-only
  patch by Charles Duffy
Daniel

16 years ago* src/qemu_driver.c: oops trailing blanks
Daniel Veillard [Mon, 3 Nov 2008 15:52:55 +0000 (15:52 +0000)]
* src/qemu_driver.c: oops trailing blanks
Daniel

16 years agoIgnore generated makefile
Daniel P. Berrange [Mon, 3 Nov 2008 12:31:53 +0000 (12:31 +0000)]
Ignore generated makefile

16 years agoGive iSCSI and disk storage backend drivers the
Chris Lalancette [Mon, 3 Nov 2008 11:37:11 +0000 (11:37 +0000)]
Give iSCSI and disk storage backend drivers the
ability to resolve any kind of volume path to the pool target volume
path.  For instance, if the pool was defined with a
<target><path>/dev/disk/by-id</path></target> section, and one of the
volumes is /dev/disk/by-id/scsi-S_beaf11, then you would be able to
call virStorageVolLookupByPath("/dev/sdc"), and get the correct volume
back.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years ago* python/virConnect.py: needed for events from the python bindings
Daniel Veillard [Fri, 31 Oct 2008 13:56:47 +0000 (13:56 +0000)]
* python/virConnect.py: needed for events from the python bindings
  by Ben Guthro
daniel

16 years ago* src/xm_internal.c: add minimum domain memory size check for Xen
Daniel Veillard [Fri, 31 Oct 2008 13:06:17 +0000 (13:06 +0000)]
* src/xm_internal.c: add minimum domain memory size check for Xen
  patch by Shigeki Sakamoto
* AUTHORS: add Shigeki Sakamoto
Daniel

16 years ago* python/Makefile.am python/generator.py python/libvir.c
Daniel Veillard [Fri, 31 Oct 2008 10:13:45 +0000 (10:13 +0000)]
* python/Makefile.am python/generator.py python/libvir.c
  python/libvir.py python/libvirt_wrap.h python/types.c:
  adds support for events from the python bindings, also
  improves the generator allowing to embbed per function
  definition files, patch by Ben Guthro
* examples/domain-events/events-python/event-test.py: also
  adds a programming example
Daniel

16 years agoAdd a test storage driver.
Cole Robinson [Thu, 30 Oct 2008 17:40:57 +0000 (17:40 +0000)]
Add a test storage driver.

16 years ago* docs/relatedlinks.html docs/relatedlinks.html.in: add link
Daniel Veillard [Wed, 29 Oct 2008 15:34:12 +0000 (15:34 +0000)]
* docs/relatedlinks.html docs/relatedlinks.html.in: add link
  for AMQP/QPid bindings
daniel

16 years ago* src/domain_conf.h src/qemu_driver.c: patch adding hor removal of
Daniel Veillard [Wed, 29 Oct 2008 14:32:40 +0000 (14:32 +0000)]
* src/domain_conf.h src/qemu_driver.c: patch adding hor removal of
  scsi/virtio disks for KVM, patch by Guido Günther
daniel

16 years agoremove src/socketcompat.h; no longer needed
Jim Meyering [Tue, 28 Oct 2008 19:09:04 +0000 (19:09 +0000)]
remove src/socketcompat.h;  no longer needed

* src/socketcompat.h: Remove file.
* src/remote_internal.c: Don't include socketcompat.h.
* qemud/qemud.h: Likewise.
* qemud/remote_protocol.x: Likewise, but do include <arpa/inet.h>
for htonl.
* src/remote_internal.c: Likewise, but do include <errno.h>.
* qemud/remote_protocol.c: Regenererate.
* qemud/remote_protocol.h: Regenererate.
* src/Makefile.am (REMOTE_DRIVER_SOURCES): Remove socketcompat.h.

16 years agomake generated qemud/*.[ch] files read-only
Jim Meyering [Tue, 28 Oct 2008 17:48:11 +0000 (17:48 +0000)]
make generated qemud/*.[ch] files read-only

* qemud/Makefile.am (.x.c): Rewrite not to write directly to $@,
and to make generated files read-only.
(.x.h): Likewise.

16 years agoavoid compiler warning when all storage backends are disabled
Jim Meyering [Tue, 28 Oct 2008 17:48:06 +0000 (17:48 +0000)]
avoid compiler warning when all storage backends are disabled

* src/storage_backend.c (backends): Add a NULL terminator.
(virStorageBackendForType): Use NULL terminator rather than
warning-provoking (possibly 0) array size.

16 years agoavoid many mingw-specific warnings
Jim Meyering [Tue, 28 Oct 2008 17:48:01 +0000 (17:48 +0000)]
avoid many mingw-specific warnings

* tests/virshtest.c (mymain): Use only one definition of this function.
[WIN32]: Call exit(77) to skip the test.
* tests/nodeinfotest.c: Likewise.

16 years agocvsignore mingw build artifacts: *.exe
Jim Meyering [Tue, 28 Oct 2008 17:47:54 +0000 (17:47 +0000)]
cvsignore mingw build artifacts: *.exe

16 years agoinclude netinet etc #ifndef HAVE_WINSOCK2_H
Jim Meyering [Tue, 28 Oct 2008 17:47:45 +0000 (17:47 +0000)]
include netinet etc #ifndef HAVE_WINSOCK2_H

16 years ago* src/remote_internal.c (remoteFindDaemonPath) [!WIN32]: Don't compile.
Jim Meyering [Tue, 28 Oct 2008 17:47:40 +0000 (17:47 +0000)]
* src/remote_internal.c (remoteFindDaemonPath) [!WIN32]: Don't compile.

16 years agouse errno, not socket_errno()
Jim Meyering [Tue, 28 Oct 2008 17:47:33 +0000 (17:47 +0000)]
use errno, not socket_errno()

* remote_internal.c: s/socket_errno()/errno/, now that gnulib's
socket module ensures errno is useful in those cases.

16 years agosocketcompat.h: simplify, to match latest gnulib
Jim Meyering [Tue, 28 Oct 2008 17:47:23 +0000 (17:47 +0000)]
socketcompat.h: simplify, to match latest gnulib

Now, sys/socket.h is always available, and errno works.

16 years agoupdates from gnulib
Jim Meyering [Tue, 28 Oct 2008 17:47:12 +0000 (17:47 +0000)]
updates from gnulib

16 years agouse more gnulib modules
Jim Meyering [Tue, 28 Oct 2008 17:46:07 +0000 (17:46 +0000)]
use more gnulib modules

* bootstrap: use more gnulib modules: close, connect, perror, recv,
send, socket setsockopt, gethostname.

16 years agoadapt to API change in gnulib
Jim Meyering [Tue, 28 Oct 2008 17:46:00 +0000 (17:46 +0000)]
adapt to API change in gnulib

* qemud/qemud.c: Include <netdb.h>, not "getaddrinfo.h"
* src/remote_internal.c: Likewise.

16 years ago* src/network_conf.c: Include <string.h> for declaration of memcmp.
Jim Meyering [Tue, 28 Oct 2008 17:45:41 +0000 (17:45 +0000)]
* src/network_conf.c: Include <string.h> for declaration of memcmp.

16 years agouse ARRAY_CARDINALITY more
Jim Meyering [Tue, 28 Oct 2008 17:43:24 +0000 (17:43 +0000)]
use ARRAY_CARDINALITY more

* tests/nodeinfotest.c: Include "util.h".
* src/xen_internal.c: Likewise.
* src/qemu_conf.c (qemudCapsInit): Use ARRAY_CARDINALITY.
* src/storage_backend.c (virStorageBackendForType): Likewise.
* src/storage_backend_fs.c (virStorageBackendProbeFile): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesInternal): Likewise.
* src/xend_internal.c (xenDaemonParseSxpr): Likewise.
* tests/nodeinfotest.c (mymain): Likewise.
* tests/qparamtest.c (DO_TEST): Likewise.

16 years agoexempt gnulib from write-avoidance syntax check
Jim Meyering [Tue, 28 Oct 2008 17:42:41 +0000 (17:42 +0000)]
exempt gnulib from write-avoidance syntax check

16 years agoexempt gnulib from ctype-macros prohibition
Jim Meyering [Tue, 28 Oct 2008 17:36:31 +0000 (17:36 +0000)]
exempt gnulib from ctype-macros prohibition

Author: Jim Meyering <meyering@redhat.com>

16 years agoRemove use of sys/poll.h on mingw
Daniel P. Berrange [Fri, 24 Oct 2008 13:10:30 +0000 (13:10 +0000)]
Remove use of sys/poll.h on mingw

16 years agoFix syntax check errors
Daniel P. Berrange [Fri, 24 Oct 2008 12:05:39 +0000 (12:05 +0000)]
Fix syntax check errors

16 years agoImplement getVersion API for openvz driver
Daniel P. Berrange [Fri, 24 Oct 2008 11:32:48 +0000 (11:32 +0000)]
Implement getVersion API for openvz driver

16 years agoFix mingw build due to missing icons in tar.gz
Daniel P. Berrange [Fri, 24 Oct 2008 11:31:15 +0000 (11:31 +0000)]
Fix mingw build due to missing icons in tar.gz

16 years agoCentralize domain mac address handling in domain_conf.c/util.c
Daniel P. Berrange [Fri, 24 Oct 2008 11:20:08 +0000 (11:20 +0000)]
Centralize domain mac address handling in domain_conf.c/util.c

16 years agofix mingw compilation warning
Jim Meyering [Fri, 24 Oct 2008 08:55:13 +0000 (08:55 +0000)]
fix mingw compilation warning

* src/libvirt.c (winsock_init) [HAVE_WINSOCK2_H]: Always return a value.

16 years agoBrown paper bag bug. I didn't preserve the
Chris Lalancette [Thu, 23 Oct 2008 13:21:01 +0000 (13:21 +0000)]
Brown paper bag bug.  I didn't preserve the
<sources> tags properly, and I didn't put the <source> tag into the
proper place, so I totally changed the output of the discovery XML.
Fix this up to do the right thing.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoMassive patch adding event APIs by Ben Guthro
Daniel Veillard [Thu, 23 Oct 2008 13:18:18 +0000 (13:18 +0000)]
Massive patch adding event APIs by Ben Guthro
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in
  src/libvirt.c src/libvirt_sym.version: new libvirt event entry
  points, big patch provided by Ben Guthro
* Makefile.am configure.in src/driver.h src/event.c src/event.h
  src/internal.h src/libvirt.c src/libvirt_sym.version src/lxc_driver.c
  src/openvz_driver.c src/qemu_conf.h src/qemu_driver.c
  src/remote_internal.c src/storage_backend_fs.c src/test.c
  qemud/event.c qemud/event.h qemud/mdns.c qemud/qemud.c
  qemud/qemud.h qemud/remote.c qemud/remote_dispatch_localvars.h
  qemud/remote_dispatch_proc_switch.h qemud/remote_dispatch_prototypes.h
  qemud/remote_protocol.c qemud/remote_protocol.h
  qemud/remote_protocol.x proxy/Makefile.am python/generator.py:
  Not much is left untouched by the patch adding the events support
* docs/libvirt-api.xml docs/libvirt-refs.xml
  docs/html/libvirt-libvirt.html: regenerated the docs
* examples/domain-events/events-c/Makefile.am
  examples/domain-events/events-c/event-test.c: a test example
* AUTHORS: added Ben Guthro
daniel

16 years ago* docs/apps.html docs/apps.html.in: update monitoring apps section
Daniel Veillard [Thu, 23 Oct 2008 11:42:42 +0000 (11:42 +0000)]
* docs/apps.html docs/apps.html.in: update monitoring apps section
Daniel

16 years agoAn updated patch for adding <device> tags to logical
Chris Lalancette [Thu, 23 Oct 2008 11:39:53 +0000 (11:39 +0000)]
An updated patch for adding <device> tags to logical
findPoolSources.  Given danpb's last feedback, I completely removed the XML
parsing and did it all with structures.  The result should (hopefully) be a lot
easier on the eyes, and is a little more generic.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoAs suggested by danpb, to fix up the regression caused by last week's VIR_ENUM
Chris Lalancette [Thu, 23 Oct 2008 11:32:22 +0000 (11:32 +0000)]
As suggested by danpb, to fix up the regression caused by last week's VIR_ENUM
cleanup patch, add a ".defaultFormat" member to .poolOptions.  In
storage_conf.c, if virXPathString(/pool/source/format/@type) returns NULL, then
set the pool type to .defaultFormat; otherwise, lookup the type via
formatFromString.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoFix syntax error that was breaking RPM builds.
Cole Robinson [Wed, 22 Oct 2008 13:55:15 +0000 (13:55 +0000)]
Fix syntax error that was breaking RPM builds.

16 years agoCurrently, you can define a logical storage pool with something like:
Chris Lalancette [Tue, 21 Oct 2008 17:23:38 +0000 (17:23 +0000)]
Currently, you can define a logical storage pool with something like:
<pool type='logical'>
<source>
<name>MyVG</name>
<device name='/dev/sdb'/>
...

However, dumping out the XML for this same storage pool (with, say, virsh
pool-dumpxml), gives:

<pool type='logical'>
<source>
<name>MyVG</name>
<device name='/dev/sdb'>
</device>

To make this more idempotent, do the <device name='/dev/sdb'/> form by default,
and only do the <device>...</device> form if .nfreeExtent is defined for the
storage pool.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoBecause of my patch last week that converted the various virStorage*FromString
Chris Lalancette [Tue, 21 Oct 2008 17:18:45 +0000 (17:18 +0000)]
Because of my patch last week that converted the various virStorage*FromString
and virStorage*ToString implementations to the generic VIR_ENUM_IMPL, there were
a couple of places that didn't properly set errors when they failed.  This patch
fixes these places up.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoWhile doing on this patch series, I mistakenly added a bogus piece of
Chris Lalancette [Tue, 21 Oct 2008 17:15:53 +0000 (17:15 +0000)]
While doing on this patch series, I mistakenly added a bogus piece of
storage XML to libvirtd, which was saved in /etc/libvirt/storage.  On subsequent
stop/start of libvirtd, because of another bug , an
error wasn't being set properly in an error path, so libvirtd was SEGV'ing in
storage_conf.c:virStoragePoolObjLoad when trying to dereference the NULL err
returned from virGetLastError().  Make this more robust against errors by always
doing "err ? err->message : NULL" in the printf.  I looked around the tree and
found a couple of other places that weren't guarded, so this patch fixes them as
well.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoFix up cgroup initialization order and allow /dev/pts device access in LXC
Dan Smith [Tue, 21 Oct 2008 16:46:47 +0000 (16:46 +0000)]
Fix up cgroup initialization order and allow /dev/pts device access in LXC

16 years agoDocument somme commit rules, and add application monitoring links to docs
Daniel Veillard [Tue, 21 Oct 2008 14:26:59 +0000 (14:26 +0000)]
Document somme commit rules, and add application monitoring links to docs
* HACKING: update with some rules for commiters
* docs/apps.html docs/apps.html.in: add a section on monitoring
  support
daniel

16 years ago* src/qemu_driver.c: cleanup patch for usb masstorage hotadd
Daniel Veillard [Tue, 21 Oct 2008 13:09:23 +0000 (13:09 +0000)]
* src/qemu_driver.c: cleanup patch for usb masstorage hotadd
  by Guido Günther
daniel

16 years agoALL_LINGUAS: set unconditionally, using $srcdir/po
Jim Meyering [Tue, 21 Oct 2008 07:47:29 +0000 (07:47 +0000)]
ALL_LINGUAS: set unconditionally, using $srcdir/po

* configure.in: Remove hard-coded list altogether.

16 years agoALL_LINGUAS: remove "no", now that it's superseded by np.po
Jim Meyering [Sun, 19 Oct 2008 09:56:47 +0000 (09:56 +0000)]
ALL_LINGUAS: remove "no", now that it's superseded by np.po

* configure.in: Remove "no" from hard-coded list.

16 years ago* src/qemu_driver.c: add scsi/virtio hotplug support for KVM
Daniel Veillard [Fri, 17 Oct 2008 12:36:39 +0000 (12:36 +0000)]
* src/qemu_driver.c: add scsi/virtio hotplug support for KVM
  patch by Guido Günther
daniel

16 years agoMakefile.maint (sync-vcs-ignore-files): avoid risk of abuse
Jim Meyering [Fri, 17 Oct 2008 12:04:27 +0000 (12:04 +0000)]
Makefile.maint (sync-vcs-ignore-files): avoid risk of abuse

* Makefile.maint (sync-vcs-ignore-files): Rewrite rule so that
it won't misbehave even with maliciously-named sub-directories.

16 years agogenerate .gitignore files from .cvsignore ones
Jim Meyering [Fri, 17 Oct 2008 10:03:15 +0000 (10:03 +0000)]
generate .gitignore files from .cvsignore ones

* Makefile.maint (sync-vcs-ignore-files): New target.
Prompted by a patch from James Morris.
http://thread.gmane.org/gmane.comp.emulators.libvirt/8619/focus=8773
Add all (now-generated) .gitignore files.
* .gitignore: New file.
* build-aux/.gitignore: New file.
* docs/.gitignore: New file.
* docs/devhelp/.gitignore: New file.
* docs/examples/.gitignore: New file.
* docs/examples/python/.gitignore: New file.
* gnulib/lib/.gitignore: New file.
* gnulib/lib/arpa/.gitignore: New file.
* gnulib/lib/netinet/.gitignore: New file.
* gnulib/lib/sys/.gitignore: New file.
* gnulib/tests/.gitignore: New file.
* include/.gitignore: New file.
* include/libvirt/.gitignore: New file.
* po/.gitignore: New file.
* proxy/.gitignore: New file.
* python/.gitignore: New file.
* python/tests/.gitignore: New file.
* qemud/.gitignore: New file.
* src/.gitignore: New file.
* tests/.gitignore: New file.
* tests/confdata/.gitignore: New file.
* tests/sexpr2xmldata/.gitignore: New file.
* tests/virshdata/.gitignore: New file.
* tests/xencapsdata/.gitignore: New file.
* tests/xmconfigdata/.gitignore: New file.
* tests/xml2sexprdata/.gitignore: New file.

16 years agogenerate .gitignore files from .cvsignore ones
Jim Meyering [Fri, 17 Oct 2008 09:59:02 +0000 (09:59 +0000)]
generate .gitignore files from .cvsignore ones

* Makefile.maint (sync-vcs-ignore-files): New target.
Prompted by a patch from James Morris.
http://thread.gmane.org/gmane.comp.emulators.libvirt/8619/focus=8773
Add all (now-generated) .gitignore files.
* .gitignore: New file.
* build-aux/.gitignore: New file.
* docs/.gitignore: New file.
* docs/devhelp/.gitignore: New file.
* docs/examples/.gitignore: New file.
* docs/examples/python/.gitignore: New file.
* gnulib/lib/.gitignore: New file.
* gnulib/lib/arpa/.gitignore: New file.
* gnulib/lib/netinet/.gitignore: New file.
* gnulib/lib/sys/.gitignore: New file.
* gnulib/tests/.gitignore: New file.
* include/.gitignore: New file.
* include/libvirt/.gitignore: New file.
* po/.gitignore: New file.
* proxy/.gitignore: New file.
* python/.gitignore: New file.
* python/tests/.gitignore: New file.
* qemud/.gitignore: New file.
* src/.gitignore: New file.
* tests/.gitignore: New file.
* tests/confdata/.gitignore: New file.
* tests/sexpr2xmldata/.gitignore: New file.
* tests/virshdata/.gitignore: New file.
* tests/xencapsdata/.gitignore: New file.
* tests/xmconfigdata/.gitignore: New file.
* tests/xml2sexprdata/.gitignore: New file.

16 years agoqemudDomainBlockStats use qemudDiskDeviceName
Daniel Veillard [Fri, 17 Oct 2008 09:29:29 +0000 (09:29 +0000)]
qemudDomainBlockStats use qemudDiskDeviceName
* src/qemu_driver.c: use qemudDiskDeviceName to determine the block
  device name in qemudDomainBlockStats(), patch by Guido Günther
daniel

16 years ago* src/qemu_driver.c: fix qemudDiskDeviceName to handle disk devices
Daniel Veillard [Fri, 17 Oct 2008 09:24:07 +0000 (09:24 +0000)]
* src/qemu_driver.c: fix qemudDiskDeviceName to handle disk devices
  too, patch by Guido Günther
daniel

16 years ago* src/domain_conf.c: fix virDiskNameToBusDeviceIndex() to allow 0
Daniel Veillard [Fri, 17 Oct 2008 09:18:21 +0000 (09:18 +0000)]
* src/domain_conf.c: fix virDiskNameToBusDeviceIndex() to allow 0
  patch by Guido Günther
Daniel

16 years agobuild: when po-check fails, say why and suggest a fix
Jim Meyering [Thu, 16 Oct 2008 17:18:48 +0000 (17:18 +0000)]
build: when po-check fails, say why and suggest a fix

* Makefile.maint (po-check): Before, when this check failed, it just
spat out a diff mentioning two temporary files.  Now, it tells you
what's wrong and suggests a fix with a patch using the name of the
affected file (rather than temporary file names) in the diff output.

16 years agoAdd support for detecting the partition table type when scanning
Chris Lalancette [Thu, 16 Oct 2008 15:06:03 +0000 (15:06 +0000)]
Add support for detecting the partition table type when scanning
iSCSI volumes.  This is implemented in the
virStorageBackendUpdateVolInfoFD function, so all future callers will
automatically benefit.  This is a somewhat large patch because the
conversion of the virStorageBackendPartTableTypeToString necessitated
a change to the formatToString and formatFromString function pointers,
which caused fallout in other places in the storage stuff.  The good
news is that most of these callers are now converted over to the
VIR_ENUM_IMPL, which means a lot of redundant code is now gone.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agoCompiling with -Werror showed a possible use before initialization
Chris Lalancette [Thu, 16 Oct 2008 13:44:09 +0000 (13:44 +0000)]
Compiling with -Werror showed a possible use before initialization
in src/qemu_driver.c.  Make sure to initialize the olddisk ptr to NULL.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years agobuild: exempt *.ico files from the trailing blank check
Jim Meyering [Thu, 16 Oct 2008 13:28:07 +0000 (13:28 +0000)]
build: exempt *.ico files from the trailing blank check

* .x-sc_trailing_blank: Add \.ico$ to the list.

16 years ago"make syntax-check" was complaining that network_driver.c was missing from
Chris Lalancette [Thu, 16 Oct 2008 12:04:06 +0000 (12:04 +0000)]
"make syntax-check" was complaining that network_driver.c was missing from
POTFILES.in.  Add it there, and then fix up one warning about included
c-ctypes.h that wasn't being used.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
16 years ago* configure.in, src/Makefile.am, src/virsh_win_icon.rc:
Richard W.M. Jones [Wed, 15 Oct 2008 18:39:34 +0000 (18:39 +0000)]
* configure.in, src/Makefile.am, src/virsh_win_icon.rc:
Add a Windows icon resource.

16 years ago* src/libvirt.c: Register the remote driver even when we are
Richard W.M. Jones [Wed, 15 Oct 2008 10:33:01 +0000 (10:33 +0000)]
* src/libvirt.c: Register the remote driver even when we are
        configured --without-libvirtd.  Also adds debugging of
        registration events.