xenbits.xensource.com Git - libvirt.git/log

]> xenbits.xensource.com Git - libvirt.git/log

John Ferlan [Mon, 2 Apr 2018 11:09:28 +0000 (07:09 -0400)]

remote: Fix usage of ATTRIBUTE_FALLTHROUGH

Move to within the #if since the #else portion ends with a goto
and that raised concern by Coverity.

Signed-off-by: John Ferlan <jferlan@redhat.com>

commit | commitdiff | tree

John Ferlan [Wed, 8 Nov 2017 12:13:20 +0000 (07:13 -0500)]

conf: Add error checking to virDomainSnapshotDiskDefFormat

Commit id '43f2ccdc' called virDomainDiskSourceDefFormatInternal
rather than formatting the the disk source inline. However, it
did not handle the case where the helper failed. Over time the
helper has been renamed to virDomainDiskSourceFormat. Similar to
other consumers, if virDomainDiskSourceFormat fails, then the
formatting could be off, so it's better to fail than to continue
on with some possibly bad data. Alter the function and the caller
to check status and jump to error in that case.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>

commit | commitdiff | tree

Michal Privoznik [Thu, 12 Apr 2018 12:39:43 +0000 (14:39 +0200)]

qemu_capabilities: Separate out device props fetching

The code is generic enough to be reused. Move it into a
separate function.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

commit | commitdiff | tree

Michal Privoznik [Thu, 12 Apr 2018 11:31:03 +0000 (13:31 +0200)]

qemu_capabilities: s/ObjectProps/DeviceProps/g

So far all the properties we are trying to fetch are device
properties, i.e. -device $dev on qemu command line. Change
misleading variable names to express what's queried for better.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

commit | commitdiff | tree

Andrea Bolognani [Tue, 10 Apr 2018 14:12:05 +0000 (16:12 +0200)]

qemu: Figure out nodeset bitmap size correctly

The current private XML parsing code relies on the assumption
that NUMA node IDs start from 0 and are densely allocated,
neither of which is necessarily the case.

Change it so that the bitmap size is dynamically calculated by
looking at NUMA node IDs instead, which ensures all nodes will
be able to fit and thus the bitmap will be parsed successfully.

Update one of the test cases so that it would fail with the
previous approach, but passes with the new one.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1490158

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

commit | commitdiff | tree

Andrea Bolognani [Tue, 10 Apr 2018 15:42:14 +0000 (17:42 +0200)]

tests: Create full host NUMA topology in more cases

vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.

While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.

Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

commit | commitdiff | tree

Michal Privoznik [Wed, 18 Apr 2018 08:49:00 +0000 (10:49 +0200)]

qemuDomainObjPrivateDataClear: Don't leak @migParams

Allocated in qemuMigrationParamsNew() we need to free
priv->job.migParams when no longer needed.

==8061== 234 (192 direct, 42 indirect) bytes in 1 blocks are definitely lost in loss record 112 of 123
==8061==    at 0x4C2CF26: calloc (vg_replace_malloc.c:711)
==8061==    by 0x5325D05: virAlloc (viralloc.c:144)
==8061==    by 0x1984F9: qemuMigrationParamsNew (qemu_migration_params.c:218)
==8061==    by 0x19A352: qemuMigrationParamsParse (qemu_migration_params.c:1185)
==8061==    by 0x1604D8: qemuDomainObjPrivateXMLParseJob (qemu_domain.c:2390)
==8061==    by 0x160AE9: qemuDomainObjPrivateXMLParse (qemu_domain.c:2517)
==8061==    by 0x5419EAE: virDomainObjParseXML (domain_conf.c:20442)
==8061==    by 0x541A25E: virDomainObjParseNode (domain_conf.c:20555)
==8061==    by 0x541A2FC: virDomainObjParseFile (domain_conf.c:20574)
==8061==    by 0x13607D: testCompareStatusXMLToXMLFiles (qemuxml2xmltest.c:75)
==8061==    by 0x14F3E8: virTestRun (testutils.c:180)
==8061==    by 0x14DCD0: mymain (qemuxml2xmltest.c:1200)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Thu, 19 Apr 2018 13:52:51 +0000 (14:52 +0100)]

po: attempt to fix srcdir != builddir builds

The .pot, .po and .gmo files are slightly unusual in that we generate
them in the srcdir when building form git. This is because they'll be
bundled in the tar archive, so a build-from-tar will see them in srcdir.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:37 +0000 (16:02 +0100)]

po: minimize language zu

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:37 +0000 (16:02 +0100)]

po: minimize language zh_TW

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:37 +0000 (16:02 +0100)]

po: minimize language zh_HK

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:37 +0000 (16:02 +0100)]

po: minimize language zh_CN

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language yo

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language wba

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language vi

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language ur

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language uk

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language tw

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language tr

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language th

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language tg

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language te

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:36 +0000 (16:02 +0100)]

po: minimize language ta

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language sv

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language sr

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language sr@latin

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language sq

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language sl

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language sk

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language si

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language ru

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language ro

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language pt

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language pt_BR

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language pl

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language pa

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:35 +0000 (16:02 +0100)]

po: minimize language or

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language nso

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language nn

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language nl

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language ne

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language nds

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language nb

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language my

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language ms

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language mr

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language mn

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language ml

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language mk

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:34 +0000 (16:02 +0100)]

po: minimize language mai

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language lv

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language lt

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language ky

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language kw@uccor

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language kw

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language kw@kkcor

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language kw_GB

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language ko

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language kn

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language km

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language kk

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language ka

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language ja

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:33 +0000 (16:02 +0100)]

po: minimize language it

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language is

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language ilo

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language id

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language ia

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language hu

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language hr

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language hi

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language he

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language gu

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language gl

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language ga

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language fur

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language fr

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language fi

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree

Daniel P. Berrangé [Fri, 6 Apr 2018 15:02:32 +0000 (16:02 +0100)]

po: minimize language fil

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

commit | commitdiff | tree