]>
xenbits.xensource.com Git - libvirt.git/log
Jim Meyering [Tue, 3 Feb 2009 21:12:22 +0000 (21:12 +0000)]
ChangeLog: reformat recent date/name/email lines
Jim Meyering [Tue, 3 Feb 2009 13:09:18 +0000 (13:09 +0000)]
avoid a format-related warning
* src/qemu_driver.c (qemudStartVMDaemon): Use "%s".
Jim Meyering [Tue, 3 Feb 2009 13:08:59 +0000 (13:08 +0000)]
build: enable redundant-const check
* Makefile.cfg (local-checks-to-skip): Remove sc_redundant_const.
* src/lxc_controller.c: Remove redundant "const"(s).
* src/storage_backend_fs.c: Likewise.
* src/util.h: Likewise.
* src/xen_internal.c: Likewise.
* tests/qparamtest.c: Likewise.
Jim Meyering [Tue, 3 Feb 2009 13:08:36 +0000 (13:08 +0000)]
syntax-check: enable more checks
* Makefile.cfg (local-checks-to-skip): Don't skip sc_m4_quote_check.
Don't skip sc_prohibit_nonreentrant.
* Makefile.nonreentrant (NON_REENTRANT): Comment out until we've
remove all remaining uses of strerror.
Jim Meyering [Tue, 3 Feb 2009 13:08:07 +0000 (13:08 +0000)]
cleanup: remove useless if-before-VIR_FREE
* Makefile.cfg (useless_free_options): Also check for VIR_FREE.
* src/iptables.c (iptRulesFree): Remove useless if-before-VIR_FREE.
* src/remote_internal.c (remoteAuthSASL): Likewise.
* src/test.c (testOpenFromFile): Likewise.
Jim Meyering [Mon, 2 Feb 2009 20:35:14 +0000 (20:35 +0000)]
tests: diagnose more open failures
* tests/qemuxml2argvtest.c: Revert the change,
"tests: diagnose open failure" of 2009-01-30.
* tests/testutils.c (virtTestLoadFile): Diagnose failure here.
John Levon [Mon, 2 Feb 2009 18:41:56 +0000 (18:41 +0000)]
fix more printf("%s", NULL) cases
Guido Günther [Sat, 31 Jan 2009 13:49:11 +0000 (13:49 +0000)]
Don't hardcode ssh port 22, use VIR_FREE, initialize pointers to NULL not 0.
Daniel Veillard [Sat, 31 Jan 2009 11:46:29 +0000 (11:46 +0000)]
Release of 0.6.0
* configure.in docs/* NEWS: release of 0.6.0
* po/*: regenerated and updated brazilian and polish localizations
daniel
Daniel Veillard [Sat, 31 Jan 2009 09:14:58 +0000 (09:14 +0000)]
* docs/news.html*: update with infos for 0.6.0
* docs/*: regenerated some data too
daniel
Jim Meyering [Fri, 30 Jan 2009 21:59:35 +0000 (21:59 +0000)]
tests: diagnose open failure
* tests/qemuxml2argvtest.c (testCompareXMLToArgvFiles): Diagnose
failure to open an input file.
Daniel P. Berrange [Fri, 30 Jan 2009 21:52:22 +0000 (21:52 +0000)]
Fix empty declaration in enum declaration
Daniel P. Berrange [Fri, 30 Jan 2009 21:49:12 +0000 (21:49 +0000)]
Added missing shared disk test case
Jim Meyering [Fri, 30 Jan 2009 19:57:20 +0000 (19:57 +0000)]
fix qemud version reporting when qemu is not installed
* src/qemu_conf.c (uname_normalize): New function, factored out of...
(qemudBuildCommandLine): ...here. Use the new function.
(qemudExtractVersion): Use it here, rather than hard-coding "i686".
Daniel P. Berrange [Fri, 30 Jan 2009 17:17:58 +0000 (17:17 +0000)]
Fix ifname= passing to QEMU for type=ethernet network config
Daniel P. Berrange [Fri, 30 Jan 2009 17:15:39 +0000 (17:15 +0000)]
Support disk caching mode config
Daniel P. Berrange [Fri, 30 Jan 2009 17:12:28 +0000 (17:12 +0000)]
Fix crash using bogus arch in QEMU
Daniel P. Berrange [Fri, 30 Jan 2009 17:07:29 +0000 (17:07 +0000)]
Fix numerous bugs in QEMU domain startup
Daniel P. Berrange [Fri, 30 Jan 2009 16:51:33 +0000 (16:51 +0000)]
Fix valgrind crash in LXC & avoid probing unneccessarily
Daniel P. Berrange [Fri, 30 Jan 2009 16:48:52 +0000 (16:48 +0000)]
Fix leak of storage vols when freeing pool
Daniel P. Berrange [Fri, 30 Jan 2009 16:48:02 +0000 (16:48 +0000)]
Fix leak in serializing error message from daemon to client
John Levon [Fri, 30 Jan 2009 15:43:05 +0000 (15:43 +0000)]
Fix yet another printf("%s", NULL) case
Fix getpwuid_r() usage
Fix virsh migrateuri handling
Daniel P. Berrange [Thu, 29 Jan 2009 23:01:37 +0000 (23:01 +0000)]
Misc xen driver bug/crash fixes
John Levon [Thu, 29 Jan 2009 18:40:32 +0000 (18:40 +0000)]
Fix xend XML generation when CPU pinning is used
Jim Meyering [Thu, 29 Jan 2009 18:06:19 +0000 (18:06 +0000)]
maint: sync from coreutils
* .x-sc_prohibit_have_config_h: Renamed from...
* .x-sc_no_have_config_h: ... this.
* .x-sc_prohibit_HAVE_MBRTOWC: New file.
Daniel P. Berrange [Thu, 29 Jan 2009 17:50:00 +0000 (17:50 +0000)]
Support VNC password setting in QEMU driver
Daniel P. Berrange [Thu, 29 Jan 2009 17:27:54 +0000 (17:27 +0000)]
Fix save/restore migrate syntax for new KVM releases
John Levon [Thu, 29 Jan 2009 17:18:24 +0000 (17:18 +0000)]
fix another printf("%s", NULL) case
John Levon [Thu, 29 Jan 2009 17:14:48 +0000 (17:14 +0000)]
add missing files
John Levon [Thu, 29 Jan 2009 17:05:49 +0000 (17:05 +0000)]
correctly enable floppies for HVM guests.
John Levon [Thu, 29 Jan 2009 17:02:00 +0000 (17:02 +0000)]
fix VNC port reporting when vncunused is set
Jim Meyering [Thu, 29 Jan 2009 12:11:49 +0000 (12:11 +0000)]
* Makefile.cfg: disable some new checks
Jim Meyering [Thu, 29 Jan 2009 12:11:28 +0000 (12:11 +0000)]
* Makefile.maint: sync from coreutils
Jim Meyering [Thu, 29 Jan 2009 12:10:52 +0000 (12:10 +0000)]
prohibit new uses of VIR_ERR_NO_MEMORY
* Makefile.maint (sc_prohibit_VIR_ERR_NO_MEMORY): New rule.
* .x-sc_prohibit_VIR_ERR_NO_MEMORY: New file: exceptions.
Jim Meyering [Thu, 29 Jan 2009 12:10:32 +0000 (12:10 +0000)]
error-reporting calls using VIR_ERR_NO_MEMORY: use virReportOOMError instead
* src/uml_conf.c (VIR_FROM_THIS): Define to VIR_FROM_UML.
* src/xs_internal.c (VIR_FROM_THIS): Define to VIR_FROM_XEN.
* src/xml.c (VIR_FROM_THIS): Define to VIR_FROM_XML.
* src/stats_linux.c (VIR_FROM_THIS): Define to VIR_FROM_STATS_LINUX.
* src/datatypes.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/lxc_conf.c (VIR_FROM_THIS): Define to VIR_FROM_LXC.
* src/libvirt.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/node_device_conf.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/openvz_conf.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/openvz_driver.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/conf.c (VIR_FROM_THIS): Define to VIR_FROM_CONF.
Note: this loses config_filename:config_lineno diagnostics,
but that's ok.
* src/node_device.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/sexpr.c (VIR_FROM_THIS): Define to VIR_FROM_SEXPR.
* po/POTFILES.in: remove src/sexpr.c and src/lxc_conf.c
Guido Günther [Thu, 29 Jan 2009 11:49:33 +0000 (11:49 +0000)]
don't abort if setlocale() fails
Daniel P. Berrange [Wed, 28 Jan 2009 22:07:36 +0000 (22:07 +0000)]
Fix typo & tweak variable decl
Daniel P. Berrange [Wed, 28 Jan 2009 22:00:32 +0000 (22:00 +0000)]
Stopping reading off wire after 1 complete RPC message is received
Daniel P. Berrange [Wed, 28 Jan 2009 21:53:48 +0000 (21:53 +0000)]
Fix bogus valgrind memory leak warnings in test suite
Daniel P. Berrange [Wed, 28 Jan 2009 21:33:56 +0000 (21:33 +0000)]
Solaris portability for RPC code data types
Jim Meyering [Wed, 28 Jan 2009 16:14:24 +0000 (16:14 +0000)]
remote_internal.c: fix typo that would mistakenly report OOM
* src/remote_internal.c (addrToString): Report VIR_ERR_UNKNOWN_HOST,
not VIR_ERR_NO_MEMORY.
Jim Meyering [Wed, 28 Jan 2009 16:13:46 +0000 (16:13 +0000)]
qparams.c: Use virReportOOMError(NULL), not qparam_report_oom()
* src/qparams.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
(qparam_report_oom): Remove definition.
Replace all uses.
John Levon [Wed, 28 Jan 2009 14:36:23 +0000 (14:36 +0000)]
fix mis-use of PF_UNIX as a protocol
Jim Meyering [Wed, 28 Jan 2009 14:08:33 +0000 (14:08 +0000)]
libvirt_proxy: avoid potential buffer overflow
* proxy/libvirt_proxy.c (proxyReadClientSocket): Ensure that
we've read an entire virProxyPacket before dereferencing "req".
Analysis and patch by "Rasputin" <rasputin@email.ru>. Details in
<http://thread.gmane.org/gmane.comp.emulators.libvirt/11459>.
Jim Meyering [Wed, 28 Jan 2009 13:59:56 +0000 (13:59 +0000)]
* po/POTFILES.in: Add src/lxc_conf.c
John Levon [Wed, 28 Jan 2009 13:45:50 +0000 (13:45 +0000)]
remove reference to non-existent *.res
Jim Meyering [Wed, 28 Jan 2009 11:31:39 +0000 (11:31 +0000)]
avoid printf format-mismatch warnings
* qemud/qemud.c (qemudClientReadBuf, qemudClientWriteBuf):
Use %lld and a (long long int) cast to print a ssize_t value.
Daniel P. Berrange [Tue, 27 Jan 2009 18:30:03 +0000 (18:30 +0000)]
Add support for copy-on-write storage volumes
Jim Meyering [Tue, 27 Jan 2009 15:37:34 +0000 (15:37 +0000)]
* POTFILES.in: update: remove src/lxc_conf.c; Add src/bridge.c.
Daniel P. Berrange [Tue, 27 Jan 2009 15:29:53 +0000 (15:29 +0000)]
Added complete set of RNG schemas for all XML formats
Daniel P. Berrange [Tue, 27 Jan 2009 14:49:09 +0000 (14:49 +0000)]
Added link to libvirt-qpid on front page, and docs on URI formats for each driver
Jim Meyering [Tue, 27 Jan 2009 12:26:53 +0000 (12:26 +0000)]
virterror.c: don't read beyond end of buffer upon OOM
* src/virterror.c (virReportSystemErrorFull): Fix typo in
my previous change. Patch by Daniel P. Berrange.
Mark McLoughlin [Tue, 27 Jan 2009 11:12:05 +0000 (11:12 +0000)]
kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
IFF_VNET_HDR is a tun/tap flag that allows you to send and receive
large (i.e. GSO) packets and packets with partial checksums. Setting
the flag means that every packet is proceeded by the same header which
virtio uses to communicate GSO/csum metadata.
By enabling this flag on the tap fds we create, we greatly increase
the achievable throughput with virtio_net.
However, we need to be careful to only set the flag when a) QEMU has
support for this ABI and b) the value of the flag is queryable using
the TUNGETIFF ioctl.
It's nearly five months since kvm-74 - the first KVM release with this
feature - was released. Up until now, we've not added libvirt support
because there is no clean way to detect support for this in QEMU at
runtime. A brief attempt to add a "info capabilities" monitor command
to QEMU floundered. Perfect is the enemy of good enough. Probing the
KVM version will suffice for now.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Jim Meyering [Tue, 27 Jan 2009 10:57:18 +0000 (10:57 +0000)]
fix errors in virReportSystemErrorFull
* src/virterror.c (virStrerror): New function.
(virReportSystemErrorFull): Don't leak "combined".
In fact, don't even attempt allocation.
Do include the result of formatted print in final diagnostic.
Jim Meyering [Tue, 27 Jan 2009 10:30:30 +0000 (10:30 +0000)]
use gnulib's stpcpy module
* bootstrap (modules): Add stpcpy, and pull in gnulib bits:
* gnulib/lib/stpcpy.c: New file.
* gnulib/m4/stpcpy.m4: New file.
* gnulib/lib/Makefile.am: Update.
* gnulib/m4/gnulib-cache.m4: Update.
* gnulib/m4/gnulib-comp.m4: Update.
Jim Meyering [Tue, 27 Jan 2009 10:29:55 +0000 (10:29 +0000)]
update from gnulib
Jim Meyering [Tue, 27 Jan 2009 08:50:03 +0000 (08:50 +0000)]
build: avoid format warnings
* src/proxy_internal.c (xenProxyCommand): Mark a diagnostic.
* src/xen_unified.c (xenUnifiedOpen, xenUnifiedAddDomainInfo):
Fix unmarked diagnostics by removing the diagnostic altogether:
replace each xenUnifiedError(...,VIR_ERR_NO_MEMORY call with a
call to virReportOOMError.
Jim Meyering [Tue, 27 Jan 2009 08:49:15 +0000 (08:49 +0000)]
* src/virterror.c (virErrorMsg): Correct indentation.
John Levon [Fri, 23 Jan 2009 19:18:24 +0000 (19:18 +0000)]
fix recursive lock hang in xenstore driver
Daniel P. Berrange [Fri, 23 Jan 2009 16:22:20 +0000 (16:22 +0000)]
Support QEMU disk format specification in XML
Jim Meyering [Fri, 23 Jan 2009 16:15:49 +0000 (16:15 +0000)]
.cvsignore: Add explicit list of generated files.
* .hgignore: Regenerate.
* m4/.gitignore: Regenerate.
Jim Meyering [Fri, 23 Jan 2009 14:18:43 +0000 (14:18 +0000)]
fix comment typo: s/contains/continues/
* src/libvirt.c (virStorageVolFree): Correct typo in comment.
Jim Meyering [Fri, 23 Jan 2009 13:50:59 +0000 (13:50 +0000)]
qemud: don't dereference NULL on failed virGetUserDirectory
* qemud/qemud.c (qemudInitPaths): Return right away,
upon virGetUserDirectory failure.
Jim Meyering [Fri, 23 Jan 2009 13:32:48 +0000 (13:32 +0000)]
m4: update from gnulib to avoid warnings from cutting-edge autoconf
* gnulib/m4/errno_h.m4
* gnulib/m4/gnulib-comp.m4
* gnulib/m4/multiarch.m4
Jim Meyering [Fri, 23 Jan 2009 13:32:17 +0000 (13:32 +0000)]
correct and tighten up .*ignore files
* .cvsignore: Don't ignore *.orig or *.rej. They're not build products.
Don't ignore the entire m4 directory.
* Makefile.maint (sync-vcs-ignore-files): Correct quoting.
Use sed rather than a for loop.
Search only version-controled files (for reproducibility)
* gnulib/lib/netinet/.cvsignore: Append missing newline-at-EOF,
so that the use of sed doesn't mistakenly concatenate lines.
* gnulib/lib/sys/.cvsignore: Likewise.
* m4/.cvsignore: Ignore acinclude.m4 and aclocal.m4, not *.m4.
* .hgignore: Regenerate.
* all .gitignore files: Regenerate.
Jim Meyering [Fri, 23 Jan 2009 12:29:29 +0000 (12:29 +0000)]
maint: update list of error function names and adapt
* Makefile.maint (msg_gen_function): Update list.
Remove some now-unused names, add some new ones.
* src/hash.c (virHashError): Remove unused definition.
* src/openvz_conf.h (openvzLog): Likewise.
* src/xen_unified.c: Mark newly-exposed diagnostics for translation.
John Levon [Fri, 23 Jan 2009 01:48:47 +0000 (01:48 +0000)]
parse IP address for bridge interfaces
Daniel P. Berrange [Thu, 22 Jan 2009 20:27:01 +0000 (20:27 +0000)]
use the gnulib random_r function
Daniel P. Berrange [Thu, 22 Jan 2009 19:41:48 +0000 (19:41 +0000)]
Remove use of non-reentrant POSIX apis
Jim Meyering [Thu, 22 Jan 2009 19:18:24 +0000 (19:18 +0000)]
xm_internal.c: fix locking bug: s/Lock/Unlock/
* src/xm_internal.c (xenXMDomainDefineXML): Release lock, (don't
try to acquire it) upon failure, just before returning.
John Levon [Thu, 22 Jan 2009 19:03:11 +0000 (19:03 +0000)]
generate .hgignore
John Levon [Thu, 22 Jan 2009 18:33:13 +0000 (18:33 +0000)]
Remove non-existent symbol from linker script
John Levon [Thu, 22 Jan 2009 18:29:13 +0000 (18:29 +0000)]
Support script for bridge interface type
Daniel P. Berrange [Thu, 22 Jan 2009 18:19:20 +0000 (18:19 +0000)]
Fix to xen test case for threadsafety patches
John Levon [Thu, 22 Jan 2009 17:49:41 +0000 (17:49 +0000)]
Least privilege support for Solaris
Daniel P. Berrange [Wed, 21 Jan 2009 18:11:14 +0000 (18:11 +0000)]
Make xen driver threadsafe
Mark McLoughlin [Wed, 21 Jan 2009 10:50:03 +0000 (10:50 +0000)]
If you un-install libvirt and re-install it, you get a warning
from the post-install script:
Installing : libvirt
ln: creating symbolic link `/etc/libvirt/qemu/networks/autostart/default.xml': File exists
See https://bugzilla.redhat.com/462011
Daniel P. Berrange [Tue, 20 Jan 2009 22:43:07 +0000 (22:43 +0000)]
Allow storage driver to handle daemon restarts
Daniel P. Berrange [Tue, 20 Jan 2009 22:36:10 +0000 (22:36 +0000)]
Allow virtual networks to survive daemon restart
Daniel P. Berrange [Tue, 20 Jan 2009 22:15:55 +0000 (22:15 +0000)]
Support ac97 soundcard model
Daniel P. Berrange [Tue, 20 Jan 2009 22:10:52 +0000 (22:10 +0000)]
Use global thread-local error for all python error reporting
John Levon [Tue, 20 Jan 2009 21:50:31 +0000 (21:50 +0000)]
libvirtd: respect LIBVIRT_DEBUG when logging to syslog
Daniel P. Berrange [Tue, 20 Jan 2009 21:49:05 +0000 (21:49 +0000)]
Add missing .x-sc_prohibit_nonreentrant
Daniel Veillard [Tue, 20 Jan 2009 21:34:44 +0000 (21:34 +0000)]
* src/logging.c: fix openlog() ident lifetime for Solaris
daniel
Daniel P. Berrange [Tue, 20 Jan 2009 21:05:33 +0000 (21:05 +0000)]
Refresh GNULIB, also pulling in random_r module
Daniel P. Berrange [Tue, 20 Jan 2009 20:23:53 +0000 (20:23 +0000)]
Support domain events in test driver
Daniel P. Berrange [Tue, 20 Jan 2009 20:19:55 +0000 (20:19 +0000)]
Add syntax check rule to look for non-reentrant POSIX apis
Jim Meyering [Tue, 20 Jan 2009 19:29:08 +0000 (19:29 +0000)]
don't ignore write failure
* src/network_driver.c (networkEnableIpForwarding): This function
would always return 1 (success). Now it returns 0 upon write or
close failure, being careful to preserve any errno from a write failure.
Add comments.
Daniel P. Berrange [Tue, 20 Jan 2009 19:27:11 +0000 (19:27 +0000)]
Dynamically adjust worker threads in daemon
Daniel P. Berrange [Tue, 20 Jan 2009 19:25:15 +0000 (19:25 +0000)]
Allow concurrent processing of RPC calls in daemon
Daniel P. Berrange [Tue, 20 Jan 2009 18:20:09 +0000 (18:20 +0000)]
Fix some misleading comments in XM driver
Daniel P. Berrange [Tue, 20 Jan 2009 17:47:13 +0000 (17:47 +0000)]
Remove a use of strerror() in error reporting in remote driver
Daniel P. Berrange [Tue, 20 Jan 2009 17:34:56 +0000 (17:34 +0000)]
Remove use of static data in Xen XM driver
Daniel Veillard [Tue, 20 Jan 2009 17:27:34 +0000 (17:27 +0000)]
Activate RHEL5 specific flags when needed
* libvirt.spec.in: try to autodetect when rhel5 option should be
passed to configure
Daniel
Daniel P. Berrange [Tue, 20 Jan 2009 17:19:23 +0000 (17:19 +0000)]
Remove use of static data in Xen inotify driver
Daniel P. Berrange [Tue, 20 Jan 2009 17:13:33 +0000 (17:13 +0000)]
Make error reporting threadsafe by avoiding strerror
Daniel Veillard [Tue, 20 Jan 2009 16:39:35 +0000 (16:39 +0000)]
* src/qemu_driver.c: remove a warning when printing a file offset
daniel
Daniel P. Berrange [Tue, 20 Jan 2009 16:36:34 +0000 (16:36 +0000)]
Make RPC call dispatch threaded
Daniel Veillard [Tue, 20 Jan 2009 16:10:20 +0000 (16:10 +0000)]
remove stdout_fd, stderr_fd from virDomainObj
* src/domain_conf.h src/lxc_driver.c src/uml_driver.c: virDomainObj
doesn't need stdout and stderr fields anymore, patch from
Guido Günther
daniel
Daniel Veillard [Tue, 20 Jan 2009 15:52:11 +0000 (15:52 +0000)]
* src/domain_conf.h src/qemu_driver.c: use monitor fd for QEmu/KVM
domain shutdown and read saved vm status on libvirtd startup,
last 2 patches from Guido Günther finishing up the surviving the
libvirt daemon restart
daniel