Ian Jackson [Fri, 11 Jul 2014 14:27:11 +0000 (15:27 +0100)]
ts-rumpuserxen-build: Cope with new layout, disabling bodges
The rumpsrc psuedo-submodule has been integrated with the nblibs
submodule and made into a proper submodule.
Also, in the intervening time, rumpuserxen/Config.mk now uses ?= when
setting XEN_HEADERS.
So if we detect that we have a new rumpuser-xen, we can disable:
- ad-hoc arrangements for rumpsrc
- grievous-bodge
- patching Config.mk
We consider a rumpuserxen old iff it has nblibs as a submodule and
lacks rumpsrc as a submodule.
We have to have a different name for the rumpsrc submodule (rather
than using rumpsrc), because in the new arrangements it needs to be
fetched from the location specified in rumpuserxen's .gitmodules
rather than our own configured location for the old rumpsrc. (And the
local name is in the runvars etc.)
The old runvars etc. for rumpsrc need to stay around to cope with old
rumpuserxen, for now, but are going to be obsolete. Leave some
comments about this in relevant places.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Ian Jackson [Tue, 8 Jul 2014 10:27:59 +0000 (11:27 +0100)]
adhoc-revtuple-generator: Explicitly specify refs to fetch
Some of the git trees in $c{Repos} may have been created (eg by
earlier versions of git or earlier versions of osstest) without the
usual
remote.origin.fetch = +refs/heads/*:refs/remotes/origin/*
git config setting.
Pass this refspec explicitly, instead of relying on it being set as
the default.
Amongst other things, this will prevent a possible error during
bisection
git fetch -p origin
[stuff]
fatal: bad object 3e3d5f6146c3f684f4b7bd71feffc31e1c668754
which is currently appearing in our cron mail.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Mon, 30 Jun 2014 10:13:37 +0000 (11:13 +0100)]
executive-postgresql-schema: Schema dump
We really ought to have a proper schema script. But for now, include
the output of pg_dump --schema-only on the osstestdb, for the benefit
of anyone trying to set up a hosted (rather than standalone) instance
(or just trying to see how the code works).
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
v2: New patch in v2 of the series.
Ian Jackson [Fri, 27 Jun 2014 10:20:19 +0000 (11:20 +0100)]
make-flight: Test rump kernels only when needed
Introduce a new subroutine branch_wants_rumpkernel_tests and call it
before making the rumpuserxen build and test jobs.
The default is not to include a rumpuserxen test. We include it for
rumpuserxen itself, xen, linux (in case there is a frontend/backend
incompatibility), and osstest.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Fri, 27 Jun 2014 11:45:11 +0000 (12:45 +0100)]
mg-list-all-branches: New script.
The approach here is a little unpleasant but it has the virtue of
getting the ones out of crontab too, and of not depending on the
production database (which will in any case contain obsolete flights).
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Fri, 27 Jun 2014 10:42:31 +0000 (11:42 +0100)]
submodulefixup: Tell git cache [fetch=try]
Make git_massage_url take an optional %xopts list, currently with
only GitFetchBestEffort as a possible key.
Use that in submodulefixup, unconditionally. Often the submodule
update will work fine with an older version of the submodule, and if
the submodule we get is out of date then the submodule update will
fail anyway.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Campbell [Mon, 16 Jun 2014 08:51:21 +0000 (09:51 +0100)]
Implement direct IPMI power control.
The xenuse module currently used to control some machines (specifically the ARM
marilith machines) is unreliable and subject to breakages on the xenrt server
side.
Since xenuse/xenrt is just wrapping IPMI for these machines implement direct
control via a new Osstest::PDI::impi module.
This is distinct from the existing impiextra (arbitrary ipmi commands on power
status change) because IPMI power control is not idempotent, therefore it is
necessary to query the current status before turning the machine on or off.
After this change the correct power method for a marilith node is:
ipmiextra on marilith-n0-mgmt.uk.xensource.com <user> <pass> chassis bootdev pxe;ipmi marilith-n0-mgmt.uk.xensource.com <user> <pass>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
Ian, when we discussed this on IRC you expressed a preference for using
freeipmitools, but since the existing ipmiextra module uses ipmitool I figured
it would be better to be consistent.
Ian Jackson [Mon, 9 Jun 2014 14:20:05 +0000 (15:20 +0100)]
make-flight: Do not filter the qemu-upstream-* jobs
When "qemu-xen-traditional" was the default, this filtering was
correct. But now, "qemu-xen" is the default, and that version may
also be used in other tests for ancillary functions (eg, in dom0 for
the bootloader).
So simply do all of the jobs when testing qemu-upstream-*.
Retain the old behaviour for qemu-xen-4.2-testing, which has
qemu-xen-traditional as the default. (There is no
qemu-xen-4.1-testing, and 4.3 has the change to the default.)
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Campbell [Wed, 4 Jun 2014 12:49:16 +0000 (13:49 +0100)]
cr-daily-branch: Fix URLs used for trees which should be using push gate output
For several trees we were using the upstream URL for tests of all branches when
we should have been using the push gate output on xenbits (to help isolate us
from external failures). i.e. tree_libvirt was git://libvirt.org/libvirt.git
for every branch but for branches other than libvirt it should be
git://xenbits.xen.org/libvirt.git.
This is down to a missing third argument to determine_version. Fix this for all
but osstest (which shouldn't be touched).
Tested with:
$ BRANCHES="xen-unstable libvirt rumpuserxen seabios qemu-mainline qemu-xen-unstable linux-next linuxfirmware osstest"
$ for b in $BRANCHES ; do f=T${b//-}; ./standalone make-flight -f $f $b; done
$ check() { \
f=T${1//-} ; \
echo $1 ; \
./mg-show-flight-runvars $f | \
awk '$2 ~ /^tree_/ && $3 !~ /^$|xenbits.xen.org/ { printf " %-28s %s\n", $2, $3 }' | \
sort -u; \
}
$ for b in xen-unstable libvirt rumpuserxen seabios qemu-mainline qemu-xen-unstable linux-next osstest ; do check $b; done
The presence of tree_gnulib_libvirt is expected while the
tree_rumpuserxen_rumpsrc is erroneous (I think) but not intended to be fixed
here.
Note that linuxfirmware is broken since tree_linuxfirmware should be
$GIT_KERNEL_ORG/pub/scm/linux/kernel/git/firmware/linux-firmware.git. This is
also not addressed here.
For comparison the xen-unstable check output prior to this fix was:
Ian Jackson [Wed, 4 Jun 2014 11:24:06 +0000 (12:24 +0100)]
ts-xen-build-prep: Run the backgrounded resize2fs with ionice
We wrap this in
ionice -cBest-Effort -n7
This is an attempt to stop resize2fs from starving builds of IO
bandwidth. We have been seeing that some IO-intensive build steps
(notably, configure) can take unreasonable amounts of time and we
suspect resize2fs as the culprit.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Campbell [Tue, 20 May 2014 10:54:36 +0000 (11:54 +0100)]
Tolerate outages of git://git.sv.gnu.org/gnulib.git
gnulib is a bit special in that it isn't part of a push gate and
therefore doesn't have an output repo on xenbits. This means that if
git.sv.gnu.org is down for some reason then any flight which uses it
will potentially fail, even ones which are not specifically trying to
test gnulib.git. Normally unrelated flights are isolated from 3rd
party failures because they use the relevant push gates' outputs.
The git-proxy which we use supports passing [fetch=try] as an option
which will cause it to try and fetch from upstream and fall back to
the cached version if upstream does not respond. This is exactly what
we want for gnulib.git. Proxy options in the URL are separate with a
space which we encode here as %20 to avoid having to go around adding
quotes to all the uses of shell variables which contain a URL.
Provide a helper shell function cached_repo which conditionally
arranges for the given repo to be cached with the given options only
if the osstest config sets GitCacheProxy, so as not to break uses of
osstest outside of the production environment where a cache may not be
available (of course such uses will then be subject to outages of 3rd
party repos)
It was also necessary to make repo_tree_rev_fetch_git idempotent WRT
the proxy prefix to avoid trying to clone
git://proxy/git://proxy/git://some.real.domain/foo.git.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Ian Jackson [Mon, 2 Jun 2014 10:09:17 +0000 (11:09 +0100)]
cs-bisection-step: Cope with url-less trees
Since osstest 64a9c064, some flights have a tree with an empty
tree_<foo> variable. This breaks the bisector. Make it more robust
as follows:
When searching for the basis flight, ignore not only trees with no url
specified but also ones with an empty url.
When preparing the set of trees we care about, eliminate any where the
latest flight has no url (or an empty url).
(It would still be better for the flight constructor to leave
tree_<foo> unset, and for the ts-* build script to set it in as a part
of the post-build data collection. That would allow the bisector to
work on that tree where relevant. But doing this is a task for
another day - if for no other reason than that we have to decide
whether to put it in a new variable built_tree_<foo>.)
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Fri, 23 May 2014 09:55:51 +0000 (10:55 +0100)]
ap-qemu-revision: Make it actually work
This is used (only) for obtaining lists of the corresponding qemu
revisions (for the report email) when doing a Xen push. It has never
worked because we didn't provide a type argument to git-cat-file.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Thu, 22 May 2014 11:24:19 +0000 (12:24 +0100)]
Default vcs to git
adhoc-revtuple-generator and cs-bisection-step try to guess the VCS
from the URL, by looking at the end of the URL for a suitable file
extension. If none was found, things would break.
This relies on a convention about tree URLs which is sadly no longer
being widely observed. In particular many projects have git URLs
which do not mention git.
Instead, have these scripts assume that urls which don't end in .git
or .hg are for git.
This renders hg into a second-class VCS in osstest, which is (I think)
tolerable. If it isn't, then someone ought to come up with some
better way of ensuring that the vcs is explicitly specified to
adhoc-revtuple-generator and cs-bisection-step. That would probably
be doable but is too much work right now.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Wed, 21 May 2014 11:36:02 +0000 (12:36 +0100)]
sg-run-job: Do blocked check globally, in run-job
Only run-job can fully abandon the whole job. With the previous
arrangements (in bc63a901), a blocked build job would go on to try to
run ts-logs-capture and become broken (rather than blocked).
The downside of this is that it is not possible in the future to
introduce a kind of job which can selectively carry on if some of its
dependencies fail. This notion is IMO an acceptable casualty.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Wed, 21 May 2014 10:37:48 +0000 (11:37 +0100)]
crontab: Rearrange actually-daily branches
Make them start at roughly the same time, by using cr-for-branches for
them all in one go. That increases the extent to which build hosts
will be reused (saving on reinstallations), and hence also the extent
to which the build hosts' ccache will be effective (saving on cpu).
Set them off at 04:18 UK time (currently equivalent to 21:18 Pacific
time), in the hope that at least some of them might have produced
answers during following the UK working day.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Wed, 21 May 2014 10:42:37 +0000 (11:42 +0100)]
rumpuserxen: Increase build timeout for grievous bodge
This involves copying 90Mby of data. If the test machine is busy (in
the worst case, running the kernel side of resize2fs which due to
Linux's poor IO scheduling hogs the entire IO system) it can take a
long time. In flight 26359 it was still running after 280s, when the
machine was released.
Increase the timeout to 2000s.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Campbell [Mon, 19 May 2014 11:32:16 +0000 (12:32 +0100)]
production-config: Update to pickup latest Debian Installer
Pickup the changes made in
mg-debian-installer-update: Updates for newer armhf kernels from backports.
mg-debian-installer-update: grab Xen PV domU capable images too
I have run
for i in i386 amd64 armhf ; do
OSSTEST_CONFIG=production-config ./mg-debian-installer-update wheezy $i 'firmware-bnx2'
done
on the osstest vm. Point the config to these new versions.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Campbell [Thu, 15 May 2014 10:30:39 +0000 (11:30 +0100)]
sg-run-job: check for prerequisite builds when running build jobs
For example build-$ARCH-libvirt depends on build-$ARCH for the Xen bits.
Performing this check early saves allocating, installing, preparating etc a
host just to find the prerequisite is missing.
Rename ts-xen-build-check to ts-build-check while we are there. The script
checks all prerequisite builds, not just Xen.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Campbell [Thu, 15 May 2014 10:30:35 +0000 (11:30 +0100)]
Add a flight to test seabios.org's master branch
Most of this is the usual stuff for adding a new branch.
cr-daily-branch needed to set REVISION_SEABIOS for the seabios branch and leave
it blank for others (so that Config.mk's version will be used). ts-xen-build
already consumes the resulting version runvar but needed to be taught about the
tree URL runvar.
make-flight and mfi-common are updated to only build+test seabios on x86.
The new branch is added to cr-daily-branches.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Campbell [Thu, 15 May 2014 10:30:34 +0000 (11:30 +0100)]
Add a flight to test qemu.org's ("mainline") master branch.
The naming here is slightly confused because we call our branches of qemuu on
xenbits "qemu-upstream-foo", so I went with qemu-mainline to be distinct.
I've introduced $qemuubranch along the lines of $xenbranch, it is normally set
to qemu-upstream-{X.Y,unstable} but for the qemu-mainline flight it instead
points to qemu-mainline.
I've run up to the make-flight bit of cr-daily-branch and it differs only in
the expected ways from a standard xen-unstable branch (i.e. uses xen.git#master
and qemu.git#master).
I did consider causing make-flight:job_create_test_filter_callback to omit any
test which didn't use qemuu but I decided not to because it is used for PV
qdisk backends too.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Campbell [Thu, 15 May 2014 10:35:44 +0000 (11:35 +0100)]
cr-daily-branch: Only build oldkern for xen-unstable flights
This is just supposed to be a build test, it doesn't actually get used.
There's no need to be doing this for every flight, doing it for xen-unstable
is enough
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Campbell [Mon, 28 Apr 2014 09:18:38 +0000 (10:18 +0100)]
mg-debian-installer-update: Updates for newer armhf kernels from backports.
In newer kernels sd_mod.ko requires crypto symbols, so include
kernel/crypto/*.ko in the installer overlay cpio.
Also prefer the newest versions of packages pulled in from backports, by
reversing the sort. Anchor the linux-image package name to we only pick up the
-armmp flavour and not -armmp-lpae (which is unnecessary in an installer
environment).
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Thu, 15 May 2014 15:48:56 +0000 (16:48 +0100)]
rump kernels: Provide a build job
Provide:
- test script ts-rumpuserxen-build
- recipe build-rumpuserxen
- in flights, job build-i386-rumpuserxen
- in ap-common, TREE and TREEVCS for RUMPUSERXEN and RUMPUSERXEN_RUMPSRC
mfi-common also honours REVISION_RUMPUSERXEN, but provides no way to
specify the revisions of the subtrees (the two submodules and
rumpsrc). The upstream rumpuser-xen git repository contains the
commit hashes of those.
We had to do some pretty unpleasant things to get the rumpuser-xen
build system to work with rumpsrc we cloned ourselves.
During bisection the bisector must choose a unification of the various
trees' revision graphs, into a single graph. But we do not here teach
adhoc-revtuple-generator about these interrelationships. As a result
the bisector may choose a unification inconsistent with the subtree
references in rumpuser-xen.git. This might impair the performance of
the bisector in the presence of cross-tree version incompatibilities,
but the results should be tolerable for now.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Thu, 15 May 2014 15:01:13 +0000 (16:01 +0100)]
BuildSupport: Provide some support for git submodules
* Provide a new "submodulefixup" function which, given a cloned
tree which has submodules:
- massages the .gitmodules file according to the tree_*
runvars and massage_url
- arranges for the submodules to be fetched and checked out
- stores the revisions of the submodules, as necessary
- honours any revision_ tags for the submodules
- allows the caller to give the submodules names which are
suitable for use in runvars etc. (and might differ from
the names or paths used in the supermodule)
* In a submodule, .git is actually a file containing a reference
to a subdirectory of the main git tree. Cope with that.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Wed, 14 May 2014 13:30:54 +0000 (14:30 +0100)]
BuildSupport, ts-*-build: Remove some clone-and-hack
Introduce Osstest::BuildSupport containing selectbuildhost,
builddirsprops and prepbuilddirs. The corresponding replicated code
from the various ts-*-build scripts is abolished.
Also break out xendist, which we are going to want to reuse.
No functional change.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Mon, 12 May 2014 13:36:10 +0000 (14:36 +0100)]
adhoc-people-touched-filter: Include patch authors
The git "Author:" tag of each commit should be included.
(We used to include only special pseudo-headers from the patch
comment, because the old hg practice used to be to put the committer
in the hg commit author. But git separates committer and author.)
This involves a slight refactoring.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Ian Campbell [Fri, 2 May 2014 13:08:04 +0000 (14:08 +0100)]
libvirt: Fixes for older versions of Xen
libvirt supports Xen 4.2 onwards. However:
- We were not correctly setting the libvirtbuildjob runvar on 4.3 and
earlier.
- Xen 4.2 installs to /usr not /usr/local so the CFLAGS/LDFLAGS used to build
libvirt were wrong.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Jackson [Fri, 9 May 2014 11:04:19 +0000 (12:04 +0100)]
TestSupport: stash installer files etc.
Stash the pxeboot config file, the preseed file, et al. This is done
centrally in file_link_contents.
We don't stash things whose $contents is actually a coderef because
(a) doing so would be inconvenient and (b) many of them are large and
not very interesting.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Ian Campbell [Tue, 29 Apr 2014 12:16:34 +0000 (13:16 +0100)]
ts-debian-hvm-install: increase boot_timeout to 200s
Tianocore can be slow to post, especially on large guests. We've been hitting
the 100s timeout on lake-frog and fire-frog. Even when succeeding the duration
is 90s+.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Ian Campbell [Mon, 28 Apr 2014 07:55:06 +0000 (08:55 +0100)]
production-config: Update di version again.
This contains the current version for amd64 and i386 (actually the same as
yesterday) which picks up the latest point release but for armhf this is a link
to the old (2013-12-12) image since armhf uses a backports kernel and is
unaffected by the point release but does seem to have a deendency on some newer
infrastructure (depmod et al, I think) which needs sorting out.
Ian Campbell [Wed, 23 Apr 2014 10:07:01 +0000 (11:07 +0100)]
Add libvirt build and test jobs.
I have run this through a "cr-daily-branch --real" and the push gate machinery
seem functional. The test cases run through to starting a guest which fails
because virsh support has not been implemented yet.
The libvirt.git initscript is horribly redhat specific, and the debian package
one is large and complex, so ts-libvirt-build inserts its own simple
initscript.
I have observed the autogen.sh phase taking 34 minutes on army (arm build
cluster) hence the surprisingly large timeout of an hour. The build took around
20 minutes on the same system, but I used a timeout of an hour anyway to be
safe.
The standalone wrapper is updated to handle path_libvirt in set-paths.
libvirt.git's autogen.sh involves initialising/cloning a git submodule, which
doesn't use osstest's git cache and introduces unpredicability into what is
built. Therefore ap-* are taught about a new libvirt-gnulib tree (prefixed
libvirt incase we end up with other users of gnulib in the future). However
this doesn't use the usual push gate mechanism, since this was deemed to be
overkill and just always uses the tip of gnulib. The results are recorded
though so the bisector can still operate over this tree in the event of
breakage.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Jim Fehlig <jfehlig@suse.com> Cc: Dario Faggioli <dario.faggioli@citrix.com>
Ian Jackson [Thu, 10 Apr 2014 17:20:18 +0000 (18:20 +0100)]
cr-*, ap-*: Facilities for testing linux-next
* Define the new branch's git source repo in ap-common.
* Provide a branch-settings file which disables running additional
baseline tests, listing changesets in flight reports, pushing,
and which arranges for the baseline revision for the flight
report to be determined "late", ie after the to-be-tested
versions of everything have been decided.
* When the baseline revision is to be determined "late", run
the new script ap-fetch-version-baseline-late. This is another
collection of per-branch rules. We introduce currently one
per-branch rule, for linux-next:
* The baseline version for a test of linux-next is
- the version tested by the most recent flight on the
linux-linus branch;
- provided that said version is an ancestor of the linux-next
version under test;
- otherwise we try an earlier linux-linus flight.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Thu, 10 Apr 2014 17:18:54 +0000 (18:18 +0100)]
sg-check-tested: support --git-ancestor-of
This will be used for the linux-next branch, whose baseline is the
most recently tested linux-linus which is an ancestor of the
being-tested linux-next.
We do not provide this for any VCS other than git. Hopefully we will
never need to.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Ian Jackson [Thu, 17 Apr 2014 15:06:05 +0000 (16:06 +0100)]
ts-xen-install: nodhcp: Make idempotent
If run more than once, this function would erroneously determine that
xenbr0 was the primary physical interface name and try to enroll it
into the bridge (also named xenbr0).
Instead, spot the "bridge_ports" line and use it to extract the
physical interface name. Eliminate from consideration any interfaces
matching xenbr\d+.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Tested-by: Ian Campbell <ian.campbell@citrix.com>
Ian Jackson [Thu, 17 Apr 2014 15:32:33 +0000 (16:32 +0100)]
cr-daily-branch: Print better message re lack of push
wantpush might be false because
- OSSTEST_PUSH is false (only set to true in daily-cron-settings-real)
- baseline untested (what we had here)
- "$tree" is unknown (although I think this would fail elsewhere)
- input and output revisions are the same
Print the message "Published tested tree is already up to date" only
if that's actually the case.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Tested-by: Ian Campbell <Ian.Campbell@citrix.com>
Ian Jackson [Thu, 17 Apr 2014 11:00:36 +0000 (12:00 +0100)]
preseed_base: drop obsolete references to NetGateway and NetNetmask
NetGateway and NetNetmask are not honoured (their lines in the preseed
file are commented out) and I'm not aware of anyone who sets them.
They have been there from the dawn of time.
Removing them gets rid of this warning (which appears twice)
Use of uninitialized value in concatenation (.) or string at Osstest/Debian.pm line 432.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Acked-by: Ian Campbell <ian.campbell@citrix.com>