Adapt to new scheduling API

Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com>
Reviewed-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
Reviewed-by: Teodor Tiron <teotiron@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #11

Fix use-after-free in glue code for pthread_join

When pthread_join is called, we use uk_thread_wait to wait for the
thread to exit. However, this will also release the thread and the
metadata for the pthread in the glue code. pthread_join then calls
pthread_detach, which attempts another wait, accessing the freed
thread.

The commit changes the pte_osThreadHandle to point to the
metadata in the glue code instead of the thread itself and prevents
the metadata from being released on exit of the uk thread. This way,
pthread_detach can detect that the thread has already been released.
Metadata is freed in pte_osThreadDelete (would have caused a double
free before the patch).

Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
Reviewed-by: Vlad-Andrei <vlad_andrei.badoiu@upb.ro>
Approved-by: Simon Kuenzer <simon@unikraft.org>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Pull-Request: #2

Makefile.uk: Remove conflicting `sched_yield.c` from build process

This commit removes the conflicting function definition for `sched_yield`
located inside the extracted `sched_yield.c` by removing the source file
from the build process.

Signed-off-by: Sergiu Moga <sergiu.moga@protonmail.com>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Pull-Request: #1

No warning when assigning thread starters

Suppresses a compiler warning that happens with code that assigns
thread starters.

Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
Reviewed-by: Daniel Dinca <dincadaniel97@gmail.com>

Initialize pthread-embedded as early as possible

Because other Unikraft libraries may create threads, we
initialize pthread-embedded within the early init class.

Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
Reviewed-by: Daniel Dinca <dincadaniel97@gmail.com>

Register meta data on `uksched` thread creation callbacks

Utilizes `uksched` callback mechanism to create and delete pthread-embedded
meta data for threads. This enables using pthread-embedded API calls on
threads that were created with the native `uksched` API.

Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
Reviewed-by: Daniel Dinca <dincadaniel97@gmail.com>

lib/pthread-embedded: Support for uksignal

This patch is an update of the original.

Signed-off-by: Mihai Pogonaru <pogonarumihai@gmail.com>
Signed-off-by: Teodora Serbanescu <teo.serbanescu16@gmail.com>
Signed-off-by: Felipe Huici <felipe.huici@neclab.eu>
Reviewed-by: ARGINT DRAGOS IULIAN <dragosargint21@gmail.com>

Include missing `<stdlib.h>`

The header `<stdlib.h>` provides definitions for
`malloc()`, `calloc()` and `free()`.

Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
Reviewed-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>

Remove compile warning

Signed-off-by: George Muraru <murarugeorgec@gmail.com>
Reviewed-by: Hugo Lefeuvre <hugo.lefeuvre@neclab.eu>

Remove reference to non-existing exportsyms.uk file .

This library used to have an exportsyms.uk file, but no longer
does. When it was removed, the reference to it in Makefile.uk was not
removed, leaving a dangling reference to a non-existing file. The
recent Unikraft build system series turned this into a build error, so
this patch fixes that by removing the line.

Signed-off-by: Felipe Huici <felipe.huici@neclab.eu>
Reviewed-by: Simon Kuenzer <simon.kuenzer@neclab.eu>

Implement pthread_condattr_{getclock, setclock}

We adapt the implementation from musl.

Signed-off-by: Vlad-Andrei BĂDOIU <vlad_andrei.badoiu@stud.acs.upb.ro>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Add clockid_t field to pthread_condattr_t_

Since pthread_condattr_t is defined as pthread_condattr_t_,
we add the clockid_t field to pthread_condattr_t_. This field
is used by funcions such as pthread_condattr_getclock.

Signed-off-by: Vlad-Andrei BĂDOIU <vlad_andrei.badoiu@stud.acs.upb.ro>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Supress warning to have a clean build.

Signed-off-by: Felipe Huici <felipe.huici@neclab.eu>
Reviewed-by: Simon Kuenzer <simon.kuenzer@neclab.eu>

Use Unikraft initcall for initialization

Initialize the library by using an Unikraft initcall instead of the
constructor attribute. This is to make sure that pthread-embedded is
initialized before Unikraft calls any application constructors and
after Unikraft initialized the depending scheduler.

Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
Reviewed-by: Sharan Santhanam <sharan.santhanam@neclab.eu>

Add pthread_condattr_{get, set}clock() stubs

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@stud.acs.upb.ro>

attributes.c: Allow GNU definitions regardless of _GNU_SOURCE

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@stud.acs.upb.ro>

Remove exportsyms.uk

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@stud.acs.upb.ro>

Add != operator for pte_handle_t

Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@stud.acs.upb.ro>
Reviewed-by: Costin Lupu <costin.lupu@cs.pub.ro>

Add pthread_sigmask() stub

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Stefan Teodorescu <stefanl.teodorescu@gmail.com>

Set priority to pthread constructor

Other libraries might use the default constructor attribute and expect pthreads
to be initialised. Currently, the priority for pthread-embedded library
constructor has the highest priority (101).

Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@stud.acs.upb.ro>
Reviewed-by: Costin Lupu <costin.lupu@cs.pub.ro>

Add pte_{pop, push}_cleanup to exported symbols

These functions are used by pthread_cleanup_{pop,push}.

Signed-off-by: Cyril Soldani <cyril.soldani@uliege.be>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Sort exported symbols

Signed-off-by: Cyril Soldani <cyril.soldani@uliege.be>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Makefile.uk: Rename SUPPRESS_FLAGS to LIBPTHREAD-EMBEDDED_SUPPRESS_FLAGS

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

pthread.h: Convert pthread_t to unsigned long

The POSIX standard outlines that pthread_t is an opaque data type and no
assumption should be made about it. However, we observed that libraries and
applications assume frequently that pthread_t is a pointer or other numerical
data type and use it to identify the corresponding threads.

pthread-embedded makes the strange decision to define pthread_t as
structure, a decision that, although compliant with POSIX standards,
makes the porting process a bit challenging. Therefore we introduce a
conversion function which simply returns the first encapsulated
unsigned long value in the structure which actually points to the
underlying thread object.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Add sched.h header

Add it just to provide cpu_set_t type definition.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Export semaphore symbols

Signed-off-by: Teodora Serbanescu <teo.serbanescu16@gmail.com>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Add pthread_atfork() function

For now, Unikraft does not support fork(), so we will just print an
warning saying that.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

Makefile.uk: Restrict pointer-to-int-cast and int-to-pointer-cast warnings only to C

Otherwise we get warnings that these warnings are only C specific.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

patches: Add patch for making pte_handle a C++ structure

The CXX library requires pthe_handle to be defined as a C++ structure. This
patch also adds the overloaded operators needed by the CXX library.

Signed-off-by: Teodora Serbanescu <teo.serbanescu16@gmail.com>
Reviewed-by: Felipe Huici <felipe.huici@neclab.eu>

include/pthread.h: Guard C code for C++

Signed-off-by: Teodora Serbanescu <teo.serbanescu16@gmail.com>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

Add missing pthread functions

This patch adds some missing functions for updating threads attributes,
such as the thread name or the stack address and size. Currently we
support only the fixed stack size of 64KB.

These new functions are used by the Ruby interpreter.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

Disable atomic functions

We disable the atomic function given that we are using them as macros.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

patches: Fix atomic operations

We use atomic operations as macros because pte uses them for both int
and long types.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

Initial port of pthread-embedded to Unikraft

This is our initial port of pthread-embedded to Unikraft as external
library. For now you need newlib to make it work. When adding the
library in the dependency list, pthread-embedded should stay before
newlib (e.g. ...:$(UK_LIBS)/pthread-embedded:$(UK_LIBS)/newlib.git:...).

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

patches: Add patches for proper building of original library

Current patches include bugfixes and refinements in the original code.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

Add .gitignore

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

Add documentation

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
Reviewed-by: Florian Schmidt <florian.schmidt@neclab.eu>

Initial commit (empty)