From: Andrea Bolognani <abologna@redhat.com>
Date: Tue, 27 Jun 2017 08:28:22 +0000 (+0200)
Subject: conf: Clean up virDomainHostdevDefNew()
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=fd91ac817d681c6d7aed445978109f0b557a4fd7;p=libvirt.git

conf: Clean up virDomainHostdevDefNew()

Follow the same style as other similar functions.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 84da9e4d51..9276cd90bb 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2434,13 +2434,13 @@ void virDomainVideoDefFree(virDomainVideoDefPtr def)
 virDomainHostdevDefPtr
 virDomainHostdevDefNew(virDomainXMLOptionPtr xmlopt)
 {
-    virDomainHostdevDefPtr def = NULL;
+    virDomainHostdevDefPtr def;
 
-    if (VIR_ALLOC(def) < 0 ||
-        VIR_ALLOC(def->info) < 0) {
-        VIR_FREE(def);
+    if (VIR_ALLOC(def) < 0)
         return NULL;
-    }
+
+    if (VIR_ALLOC(def->info) < 0)
+        goto error;
 
     if (xmlopt &&
         xmlopt->privateData.hostdevNew &&