From: Michalis Pappas <michalis@unikraft.io>
Date: Thu, 14 Sep 2023 13:51:46 +0000 (+0200)
Subject: plat/common: Remove explicit APIC IRQ ACKing from handlers
X-Git-Tag: RELEASE-0.15.0~58
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=fcc7dba62dd7b48cd6fbdf7590ba3cbfeb78929e;p=unikraft%2Funikraft.git

plat/common: Remove explicit APIC IRQ ACKing from handlers

Now that the xPIC drivers provides a unified IRQ handling,
remove explicit APIC IRQ acknowledgment from handlers.

Notice: Picking individual commits in this PR will break the build.

Signed-off-by: Michalis Pappas <michalis@unikraft.io>
Reviewed-by: Marco Schlumpp <marco@unikraft.io>
Reviewed-by: Sergiu Moga <sergiu@unikraft.io>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1103
---

diff --git a/plat/common/lcpu.c b/plat/common/lcpu.c
index 88e3c32c5..94ffcee64 100644
--- a/plat/common/lcpu.c
+++ b/plat/common/lcpu.c
@@ -50,11 +50,6 @@
 #include <limits.h>
 #include <errno.h>
 
-#ifdef CONFIG_ARCH_X86_64
-/* TODO: Remove when we have unified IRQ handling */
-#include <uk/intctlr/apic.h>
-#endif /* CONFIG_ARCH_X86_64 */
-
 /**
  * Array of LCPUs, one for every CPU in the system.
  *
@@ -296,21 +291,11 @@ static int lcpu_ipi_run_handler(void *args __unused)
 	UK_ASSERT(lcpu_state_is_busy(this_lcpu->state));
 	ukarch_dec(&this_lcpu->state);
 
-#ifdef CONFIG_ARCH_X86_64
-	/* TODO: Remove when we have unified IRQ handling */
-	apic_ack_interrupt();
-#endif /* CONFIG_ARCH_X86_64 */
-
 	return 1;
 }
 
 static int lcpu_ipi_wakeup_handler(void *args __unused)
 {
-#ifdef CONFIG_ARCH_X86_64
-	/* TODO: Remove when we have unified IRQ handling */
-	apic_ack_interrupt();
-#endif /* CONFIG_ARCH_X86_64 */
-
 	/* Nothing to do */
 	return 1;
 }