From: David Woodhouse <dwmw@amazon.co.uk>
Date: Tue, 6 Aug 2024 17:21:37 +0000 (+0100)
Subject: net: Fix '-net nic,model=' for non-help arguments
X-Git-Tag: qemu-xen-4.20.0~24^2
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=fa62cb989a9146c82f8f172715042852f5d36200;p=qemu-xen.git

net: Fix '-net nic,model=' for non-help arguments

Oops, don't *delete* the model option when checking for 'help'.

Fixes: 64f75f57f9d2 ("net: Reinstate '-net nic, model=help' output as documented in man page")
Reported-by: Hans <sungdgdhtryrt@gmail.com>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Cc: qemu-stable@nongnu.org
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---

diff --git a/net/net.c b/net/net.c
index 2eb8bc9c0b..fc1125111c 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1737,7 +1737,7 @@ void net_check_clients(void)
 
 static int net_init_client(void *dummy, QemuOpts *opts, Error **errp)
 {
-    const char *model = qemu_opt_get_del(opts, "model");
+    const char *model = qemu_opt_get(opts, "model");
 
     if (is_nic_model_help_option(model)) {
         return 0;