From: Leon Romanovsky Date: Tue, 29 May 2018 11:56:13 +0000 (+0300) Subject: RDMA/mlx4: Catch FW<->SW misalignment without machine crash X-Git-Tag: v5.4.17~5884^2~26 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f77f3036264b2e0d9abd2938b8999dc9d33819ed;p=arm%2Flinux.git RDMA/mlx4: Catch FW<->SW misalignment without machine crash Any steering QP is supposed be above steering_qp_base, see function mlx4_ib_steer_qp_alloc() for it, however in case of misalignment between SW and FW, this qp_base can be wrong. Use WARN() to catch such situation without killing the machine. Signed-off-by: Leon Romanovsky Signed-off-by: Doug Ledford --- diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index 59aed458d3be..1fea1497263b 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -3017,7 +3017,10 @@ void mlx4_ib_steer_qp_free(struct mlx4_ib_dev *dev, u32 qpn, int count) dev->steering_support != MLX4_STEERING_MODE_DEVICE_MANAGED) return; - BUG_ON(qpn < dev->steer_qpn_base); + if (WARN(qpn < dev->steer_qpn_base, "qpn = %u, steer_qpn_base = %u\n", + qpn, dev->steer_qpn_base)) + /* not supposed to be here */ + return; bitmap_release_region(dev->ib_uc_qpns_bitmap, qpn - dev->steer_qpn_base,