From: John Ferlan <jferlan@redhat.com>
Date: Mon, 31 Oct 2016 19:44:34 +0000 (-0400)
Subject: qemu: Only allow 'raw' format for scsi-block using virtio-scsi
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f694f3ff6bd8a94d71582adab669b0dcd1f7bfe5;p=libvirt.git

qemu: Only allow 'raw' format for scsi-block using virtio-scsi

https://bugzilla.redhat.com/show_bug.cgi?id=1379196

Add check in qemuCheckDiskConfig for an invalid combination
of using the 'scsi' bus for a block 'lun' device and any disk
source format other than 'raw'.
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 96c4f31ccf..9adf0fe16d 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1238,6 +1238,14 @@ qemuCheckDiskConfig(virDomainDiskDefPtr disk)
             return -1;
         }
 
+        if (disk->bus == VIR_DOMAIN_DISK_BUS_SCSI &&
+            disk->src->format != VIR_STORAGE_FILE_RAW) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                           _("disk device 'lun' using target 'scsi' must use "
+                             "'raw' format"));
+            return -1;
+        }
+
         if (qemuDomainDefValidateDiskLunSource(disk->src) < 0)
             return -1;