From: Benoît Canet Date: Wed, 4 Mar 2015 17:17:12 +0000 (+0000) Subject: ide: Correct improper smart self test counter reset in ide core. X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f593f25ed367ec1fef9d826e351242498033779c;p=qemu-upstream-4.2-testing.git ide: Correct improper smart self test counter reset in ide core. The SMART self test counter was incorrectly being reset to zero, not 1. This had the effect that on every 21st SMART EXECUTE OFFLINE: * We would write off the beginning of a dynamically allocated buffer * We forgot the SMART history Fix this. Signed-off-by: Benoit Canet Message-id: 1397336390-24664-1-git-send-email-benoit.canet@irqsave.net Reviewed-by: Markus Armbruster Cc: qemu-stable@nongnu.org Acked-by: Kevin Wolf [PMM: tweaked commit message as per suggestions from Markus] Signed-off-by: Peter Maydell Signed-off-by: Stefano Stabellini --- diff --git a/hw/ide/core.c b/hw/ide/core.c index 93a1a689c..d2a481e3d 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1472,7 +1472,7 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) case 2: /* extended self test */ s->smart_selftest_count++; if(s->smart_selftest_count > 21) - s->smart_selftest_count = 0; + s->smart_selftest_count = 1; n = 2 + (s->smart_selftest_count - 1) * 24; s->smart_selftest_data[n] = s->sector; s->smart_selftest_data[n+1] = 0x00; /* OK and finished */