From: Stefano Stabellini Date: Mon, 3 Jun 2019 22:02:43 +0000 (-0700) Subject: xen/arm: fix nr_pdxs calculation X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f51027be0688540aaab61513b06a8693a37e4c00;p=people%2Fdwmw2%2Fxen.git xen/arm: fix nr_pdxs calculation pfn_to_pdx expects an address, not a size, as a parameter. Specifically, it expects the end address, then the masks calculations compensate for any holes between start and end. Thus, we should pass the end address to pfn_to_pdx. The initial pdx is stored in frametable_base_pdx, so we can subtract the result of pfn_to_pdx(start_address) from nr_pdxs; we know that we don't need to cover any memory in the range 0-start in the frametable. Remove the variable `nr_pages' because it is unused. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall CC: JBeulich@suse.com --- diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index d6953348c3..bd1942f7f1 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -858,8 +858,8 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, /* Map a frame table to cover physical addresses ps through pe */ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) { - unsigned long nr_pages = (pe - ps) >> PAGE_SHIFT; - unsigned long nr_pdxs = pfn_to_pdx(nr_pages); + unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - + mfn_to_pdx(maddr_to_mfn(ps)) + 1; unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); mfn_t base_mfn; const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32);