From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Fri, 25 Jan 2019 12:08:41 +0000 (+0000)
Subject: power: ssh: Fix handling of $delay
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f4565d88c73dacd0aa34a1cc69632e3f0da10fd2;p=osstest.git

power: ssh: Fix handling of $delay

The script fragment contains a reference to $delay which is a perl
variable, not a variable in the script fragment.  We therefore need to
not ''-quote the script.

Without this, the ssh method will often fail spuriously: the exiting
parent (which will signal success back to the osstest controller)
races with the attempt to reboot.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---

diff --git a/Osstest/PDU/ssh.pm b/Osstest/PDU/ssh.pm
index ac1eb91..cfcf8f8 100644
--- a/Osstest/PDU/ssh.pm
+++ b/Osstest/PDU/ssh.pm
@@ -47,7 +47,7 @@ sub pdu_power_state {
 
     my $delay = 5;
 
-    target_cmd_root($mo->{Host}, <<'END', 60);
+    target_cmd_root($mo->{Host}, <<END, 60);
  set -e
  type reboot
  exec >>/var/log/osstest-reboot.log