From: Paolo Bonzini Date: Tue, 16 Apr 2013 13:39:51 +0000 (+0200) Subject: memory: populate FlatView for new address spaces X-Git-Tag: qemu-xen-4.4.0-rc1~6^2~368^2~1 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f43793c7caab49c68b41c3b8524fc35b4c206856;p=qemu-upstream-4.5-testing.git memory: populate FlatView for new address spaces Even a new address space might have a non-empty FlatView. In order to initialize it properly, address_space_init should (a) call memory_region_transaction_commit after the address space is inserted into the list; (b) force memory_region_transaction_commit to do something. This bug was latent so far because all address spaces started empty, including the PCI address space where the bus master region is initially disabled. However, the target address space of an IOMMU is usually rooted at get_system_memory(), which might not be empty at the time the IOMMU is created. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- diff --git a/memory.c b/memory.c index 9478f98fd..99f046d8b 100644 --- a/memory.c +++ b/memory.c @@ -1576,8 +1576,9 @@ void address_space_init(AddressSpace *as, MemoryRegion *root) as->ioeventfds = NULL; QTAILQ_INSERT_TAIL(&address_spaces, as, address_spaces_link); as->name = NULL; - memory_region_transaction_commit(); address_space_init_dispatch(as); + memory_region_update_pending |= root->enabled; + memory_region_transaction_commit(); } void address_space_destroy(AddressSpace *as)