From: Ian Jackson Date: Mon, 1 Mar 2010 16:14:50 +0000 (+0000) Subject: passthrough: gfx_passthru: warning when vgabios rom has invalid checksum X-Git-Tag: xen-4.0.0-rc5 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f3f98c2c705fbb773e88692e016d828a060793c8;p=qemu-xen-4.4-testing.git passthrough: gfx_passthru: warning when vgabios rom has invalid checksum In the native environment, the VGABIOS, the expansion ROM on the graphics card, is placed into the 0C0000h address space, and then executed. Of course, the checksum of the ROM must be valid. After this initialization, the system BIOS, the actual BIOS of the M/B, can resize the expansion ROM code to reduce the amount of occupied space. If the system BIOS resizes it, a new checksum must be calculated and stored in the ROM image that is on the RAM. So, normally, shadowed VGABIOS, that is placed in 0C0000h, is already modified and its checksum must be recalculated. Qemu-dm copies 0C0000h's contents of the dom0 to guest's 0C0000h. Guest re-uses dom0's used-up VGABIOS. The problem that I mentioned is about this recalculated checksum. System BIOS must guarantee the checksum after the resizing, but, some M/B does not. However, after adjusting the checksum, guest seems to work, and current qemu-dm does so. The buggy system BIOS might just forgets to recalculate. Signed-off-by: Noboru Iwamatsu Acked-by: Weidong Han --- diff --git a/hw/pass-through.c b/hw/pass-through.c index ecb3d6fab..fadd358fa 100644 --- a/hw/pass-through.c +++ b/hw/pass-through.c @@ -4262,7 +4262,10 @@ static int setup_vga_pt(void) for ( c = (char*)bios; c < ((char*)bios + bios_size); c++ ) checksum += *c; if ( checksum ) + { bios[bios_size - 1] -= checksum; + PT_LOG("vga bios checksum is adjusted!\n"); + } cpu_physical_memory_rw(0xc0000, bios, bios_size, 1);