From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 28 Nov 2012 10:46:39 +0000 (+0100)
Subject: nbd-server-add: Fix the default for 'writable'
X-Git-Tag: qemu-xen-4.3.0-rc1~17^2~16^2
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f3313d23a061648c99609a4c127ed13c820f831d;p=qemu-upstream-4.6-testing.git

nbd-server-add: Fix the default for 'writable'

The documentation to this monitor command tells, that 'writable'
argument is optional and defaults to false. However, the code sets
true as the default. But since some applications may already been
using this, it's safer to fix the code and not documentation which
would break those applications.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index d1721a3e2..6b26bbf8c 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -99,7 +99,7 @@ void qmp_nbd_server_add(const char *device, bool has_writable, bool writable,
     }
 
     if (!has_writable) {
-        writable = true;
+        writable = false;
     }
     if (bdrv_is_read_only(bs)) {
         writable = false;