From: Laine Stump <laine@redhat.com>
Date: Sat, 4 Jul 2020 21:55:59 +0000 (-0400)
Subject: conf: consistently check for error when calling virSysinfoFormat()
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f0f7ad14e9529b7a26602736761c42279d94ad34;p=libvirt.git

conf: consistently check for error when calling virSysinfoFormat()

Every other caller of this function checks for an error return and
ends their formatting early if there is an error. This function
happily continues on its way.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 37d4ccf955..3a110b330f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -29581,8 +29581,10 @@ virDomainDefFormatInternalSetRootName(virDomainDefPtr def,
     if (def->resource)
         virDomainResourceDefFormat(buf, def->resource);
 
-    for (i = 0; i < def->nsysinfo; i++)
-        virSysinfoFormat(buf, def->sysinfo[i]);
+    for (i = 0; i < def->nsysinfo; i++) {
+        if (virSysinfoFormat(buf, def->sysinfo[i]) < 0)
+            goto error;
+    }
 
     if (def->os.bootloader) {
         virBufferEscapeString(buf, "<bootloader>%s</bootloader>\n",