From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 9 Nov 2023 13:31:43 +0000 (+0100)
Subject: qemumigrationcookiexmltest: Don't crash when parsing of status XML fails
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=f0643a57594353d70db8b272ae16222c9c6f0a3b;p=libvirt.git

qemumigrationcookiexmltest: Don't crash when parsing of status XML fails

Some sub-tests dereference 'data->vm' even when it is NULL.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tests/qemumigrationcookiexmltest.c b/tests/qemumigrationcookiexmltest.c
index 74302dc55f..5270e3a7e7 100644
--- a/tests/qemumigrationcookiexmltest.c
+++ b/tests/qemumigrationcookiexmltest.c
@@ -137,9 +137,17 @@ static int
 testQemuMigrationCookieParse(const void *opaque)
 {
     struct testQemuMigrationCookieData *data = (struct testQemuMigrationCookieData *) opaque;
-    qemuDomainObjPrivate *priv = data->vm->privateData;
+    qemuDomainObjPrivate *priv;
     g_auto(virBuffer) actual = VIR_BUFFER_INITIALIZER;
 
+    /* if the VM object parsing step failed there's nothing this test can do */
+    if (!data->vm) {
+        VIR_TEST_DEBUG("\nmissing VM object\n");
+        return -1;
+    }
+
+    priv = data->vm->privateData;
+
     if (!(data->cookie = qemuMigrationCookieParse(&driver,
                                                   data->vm,
                                                   data->vm->def,
@@ -314,6 +322,12 @@ testQemuMigrationCookieBlockDirtyBitmaps(const void *opaque)
         return -1;
     }
 
+    /* if the VM object parsing step failed there's nothing this test can do */
+    if (!data->vm) {
+        VIR_TEST_DEBUG("\nmissing VM object\n");
+        return -1;
+    }
+
     if (qemuMigrationCookieBlockDirtyBitmapsMatchDisks(data->vm->def,
                                                        data->cookie->blockDirtyBitmaps) < 0)
         return -1;