From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Tue, 14 Aug 2012 14:57:49 +0000 (+0100)
Subject: Revert "qemu-xen-traditional: use O_DIRECT to open disk images for IDE"
X-Git-Tag: xen-4.2.0-rc3^0
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=effd5676225761abdab90becac519716515c3be4;p=qemu-xen-4.3-testing.git

Revert "qemu-xen-traditional: use O_DIRECT to open disk images for IDE"

This reverts commit 1307e42a4b3c1102d75401bc0cffb4eb6c9b7a38.

In fact after a lengthy discussion, we came up with the conclusion
that WRITEBACK is OK for IDE.
See: http://marc.info/?l=xen-devel&m=133311527009773

Therefore revert this which was committed in error.
---

diff --git a/xenstore.c b/xenstore.c
index 8ab9ed4e2..1857160d8 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -643,7 +643,7 @@ void xenstore_parse_domain_config(int hvm_domid)
 	    }
             pstrcpy(bs->filename, sizeof(bs->filename), params);
 
-            flags = BDRV_O_NOCACHE;
+            flags = BDRV_O_CACHE_WB; /* snapshot and write-back */
             is_readonly = 0;
             if (pasprintf(&buf, "%s/mode", bpath) == -1)
                 continue;