From: Olaf Hering Date: Mon, 28 Aug 2017 09:46:21 +0000 (+0200) Subject: rombios: prevent building with PIC/PIE X-Git-Tag: RELEASE-4.8.2~7 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ecb701f38c1035e0178b0a904f058a54862162c9;p=xen.git rombios: prevent building with PIC/PIE If the default compiler silently defaults to to -fPIC/-fPIE building rombios fails: ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o 32bitbios_all.o There are undefined symbols in the BIOS: U _GLOBAL_OFFSET_TABLE_ make[10]: *** [Makefile:26: 32bitbios_all.o] Error 11 Prevent the failure by enforcing non-PIC/PIE mode. Signed-off-by: Olaf Hering Acked-by: Andrew Cooper master commit: 672949d6c61d9cba01c5b414eed9d522082f04d3 master date: 2017-06-26 14:32:46 +0100 --- diff --git a/tools/firmware/rombios/32bit/Makefile b/tools/firmware/rombios/32bit/Makefile index b0583c93df..28c15444ae 100644 --- a/tools/firmware/rombios/32bit/Makefile +++ b/tools/firmware/rombios/32bit/Makefile @@ -4,6 +4,8 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk TARGET = 32bitbios_flat.h CFLAGS += $(CFLAGS_xeninclude) -I.. -I../../../libacpi +$(call cc-option-add,CFLAGS,CC,-fno-pic) +$(call cc-option-add,CFLAGS,CC,-fno-PIE) SUBDIRS = tcgbios diff --git a/tools/firmware/rombios/32bit/tcgbios/Makefile b/tools/firmware/rombios/32bit/tcgbios/Makefile index f87d13020f..5cff4efc60 100644 --- a/tools/firmware/rombios/32bit/tcgbios/Makefile +++ b/tools/firmware/rombios/32bit/tcgbios/Makefile @@ -4,6 +4,8 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk TARGET = tcgbiosext.o CFLAGS += $(CFLAGS_xeninclude) -I.. -I../.. -I../../../../libacpi +$(call cc-option-add,CFLAGS,CC,-fno-pic) +$(call cc-option-add,CFLAGS,CC,-fno-PIE) .PHONY: all all: $(TARGET)