From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 27 Apr 2015 12:51:31 +0000 (+0200)
Subject: kvm: accept non-mapped memory in kvm_dirty_pages_log_change
X-Git-Tag: qemu-xen-4.7.0-rc1~268^2~47
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ea8cb1a8d98f5e3822a23a7cecdb4add0f29178b;p=qemu-xen.git

kvm: accept non-mapped memory in kvm_dirty_pages_log_change

It is okay if memory is not mapped into the guest but has dirty logging
enabled.  When this happens, KVM will not do anything and only accesses
from the host will be logged.

This can be triggered by iofuzz.

Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/kvm-all.c b/kvm-all.c
index c713b22f8c..36e81099fb 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -335,12 +335,10 @@ static int kvm_dirty_pages_log_change(hwaddr phys_addr,
     KVMSlot *mem = kvm_lookup_matching_slot(s, phys_addr, phys_addr + size);
 
     if (mem == NULL)  {
-        fprintf(stderr, "BUG: %s: invalid parameters " TARGET_FMT_plx "-"
-                TARGET_FMT_plx "\n", __func__, phys_addr,
-                (hwaddr)(phys_addr + size - 1));
-        return -EINVAL;
+        return 0;
+    } else {
+        return kvm_slot_dirty_pages_log_change(mem, log_dirty);
     }
-    return kvm_slot_dirty_pages_log_change(mem, log_dirty);
 }
 
 static void kvm_log_start(MemoryListener *listener,