From: Christian Ehrhardt Date: Wed, 20 Sep 2017 14:59:08 +0000 (+0200) Subject: virt-aa-helper: allow spaces in vm names X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e79211ed231c8453d4abc3fe0a66b4609016a73b;p=libvirt.git virt-aa-helper: allow spaces in vm names libvirt allows spaces in vm names, there were issues in the past but it seems not removed so the assumption has to be that spaces are continuing to be allowed. Therefore virt-aa-helper should not reject spaces in vm names anymore if it is going to be refused causing issues then the parser or xml schema should do so. Apparmor rules are in quotes, so a space in a path based on the name works. Signed-off-by: Christian Ehrhardt Signed-off-by: Michal Privoznik --- diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index d1518eab39..5f4519dc99 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -449,7 +449,7 @@ valid_name(const char *name) { /* just try to filter out any dangerous characters in the name that can be * used to subvert the profile */ - const char *bad = " /[]*"; + const char *bad = "/[]*"; if (strlen(name) == 0) return -1;