From: Manu Gautam <mgautam@codeaurora.org>
Date: Thu, 21 Dec 2017 04:24:25 +0000 (+0530)
Subject: usb: gadget: core: Fix use-after-free of usb_request
X-Git-Tag: v5.4.17~6558^2~2^2~9
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e74bd4d358e5455233f1dcc3975425905b270b91;p=arm%2Flinux.git

usb: gadget: core: Fix use-after-free of usb_request

Driver is tracing usb_request after freeing it.
Fix it by changing the order.

Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
---

diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index 859d5b11ba4c..1f8b19d9cf97 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -180,8 +180,8 @@ EXPORT_SYMBOL_GPL(usb_ep_alloc_request);
 void usb_ep_free_request(struct usb_ep *ep,
 				       struct usb_request *req)
 {
-	ep->ops->free_request(ep, req);
 	trace_usb_ep_free_request(ep, req, 0);
+	ep->ops->free_request(ep, req);
 }
 EXPORT_SYMBOL_GPL(usb_ep_free_request);