From: Kaifeng Zhu <kaifeng.zhu@citrix.com>
Date: Fri, 7 Mar 2014 15:27:36 +0000 (+0000)
Subject: qemu-char: fix memory leak in qemu_char_open_pty()
X-Git-Tag: xen-4.6.1~15
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e6af340b9e32e78fd980d46d939aa0939f51ebd4;p=qemu-xen-unstable.git

qemu-char: fix memory leak in qemu_char_open_pty()

The momery pointed by s and chr could be leaked if openpty return a value
less then 0.

Signed-off-by: Kaifeng Zhu <kaifeng.zhu@citrix.com>
Coverity-IDs: 1055926 1055927
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/qemu-char.c b/qemu-char.c
index 324ed16ec7..f62a6afb71 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -932,6 +932,8 @@ static CharDriverState *qemu_chr_open_pty(void)
     s = qemu_mallocz(sizeof(PtyCharDriver));
 
     if (openpty(&s->fd, &slave_fd, pty_name, NULL, NULL) < 0) {
+        qemu_free(s);
+        qemu_free(chr);
         return NULL;
     }