From: Paolo Bonzini <pbonzini@redhat.com>
Date: Wed, 12 Nov 2014 11:16:58 +0000 (+0100)
Subject: target-i386: fix Coverity complaints about overflows
X-Git-Tag: v2.2.0-rc2~13^2~3
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e6a33e45c270ea024929f4afb49283d610577af3;p=qemu-xen-unstable.git

target-i386: fix Coverity complaints about overflows

sipi_vector is an int; it is shifted by 12 and passed as a 64-bit value,
which makes Coverity think that we wanted (uint64_t)sipi_vector << 12.

But actually it must be between 0 and 255.  Make this explicit.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 1b2c12ad94..015f5b5276 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -1104,7 +1104,7 @@ static inline void cpu_x86_load_seg_cache(CPUX86State *env,
 }
 
 static inline void cpu_x86_load_seg_cache_sipi(X86CPU *cpu,
-                                               int sipi_vector)
+                                               uint8_t sipi_vector)
 {
     CPUState *cs = CPU(cpu);
     CPUX86State *env = &cpu->env;