From: Daniel P. Berrangé <berrange@redhat.com>
Date: Fri, 15 Mar 2024 10:47:07 +0000 (+0000)
Subject: network: ensure nparams is non-NULL and non-negative
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e5b7f1e266103b06cf00361c9f483e080e3543ad;p=libvirt.git

network: ensure nparams is non-NULL and non-negative

The typed parameter array length must be non-NULL and either 0, or a
positive number.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/libvirt-network.c b/src/libvirt-network.c
index ef17a8a04d..833b1adbff 100644
--- a/src/libvirt-network.c
+++ b/src/libvirt-network.c
@@ -1577,6 +1577,9 @@ virNetworkPortGetParameters(virNetworkPortPtr port,
     virCheckNetworkPortReturn(port, -1);
     conn = port->net->conn;
 
+    virCheckNonNullArgGoto(nparams, error);
+    virCheckNonNegativeArgGoto(*nparams, error);
+
     if (conn->networkDriver && conn->networkDriver->networkPortGetParameters) {
         int ret;
         ret = conn->networkDriver->networkPortGetParameters(port, params, nparams, flags);