From: Erik Skultety <eskultet@redhat.com>
Date: Thu, 2 Oct 2014 12:48:02 +0000 (+0200)
Subject: qemu: Fix updating balloon period in live XML
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e3a7b8740fb4be15d9ba4f49f65bb9ee743730a0;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

qemu: Fix updating balloon period in live XML

Up until now, we set memballoon period in monitor successfully, however
we did not update domain definition structure, thus dumpxml was omitting
period attribute in memballoon element

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140960
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 421faa230..7c0999871 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2460,9 +2460,15 @@ static int qemuDomainSetMemoryStatsPeriod(virDomainPtr dom, int period,
         qemuDomainObjEnterMonitor(driver, vm);
         r = qemuMonitorSetMemoryStatsPeriod(priv->mon, period);
         qemuDomainObjExitMonitor(driver, vm);
-        if (r < 0)
+        if (r < 0) {
             virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                            _("unable to set balloon driver collection period"));
+            goto endjob;
+        }
+
+        vm->def->memballoon->period = period;
+        if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm) < 0)
+            goto endjob;
     }
 
     if (flags & VIR_DOMAIN_AFFECT_CONFIG) {