From: John Ferlan Date: Thu, 28 Aug 2014 13:03:47 +0000 (-0400) Subject: virnetserverservice: Resolve Coverity ARRAY_VS_SINGLETON X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e387f4c1f15e2e1a4582d7751c6f9d4dfef4b5ce;p=libvirt.git virnetserverservice: Resolve Coverity ARRAY_VS_SINGLETON Coverity complained about the following: (3) Event ptr_arith: Performing pointer arithmetic on "cur_fd" in expression "cur_fd++". 130 return virNetServerServiceNewFD(*cur_fd++, The complaint is that pointer arithmetic taking place instead of the expected auto increment of the variable... Adding some well placed parentheses ensures our order of operation. --- diff --git a/src/rpc/virnetserverservice.c b/src/rpc/virnetserverservice.c index fea05c3e4e..647007b911 100644 --- a/src/rpc/virnetserverservice.c +++ b/src/rpc/virnetserverservice.c @@ -125,9 +125,11 @@ virNetServerServiceNewFDOrUNIX(const char *path, } else { /* * There's still enough file descriptors. In this case we'll - * use the current one and increment it afterwards. + * use the current one and increment it afterwards. Take care + * with order of operation for pointer arithmetic and auto + * increment on cur_fd - the parentheses are necessary. */ - return virNetServerServiceNewFD(*cur_fd++, + return virNetServerServiceNewFD((*cur_fd)++, auth, #if WITH_GNUTLS tls,