From: Gerd Hoffmann Date: Tue, 30 Oct 2012 13:55:12 +0000 (+0100) Subject: qxl: call dpy_gfx_resize when entering vga mode X-Git-Tag: qemu-xen-4.3.0-rc1~64^2~3 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e32c25b5f2452c7fed4dbe8962f4a9f4831fbe24;p=qemu-upstream-4.4-testing.git qxl: call dpy_gfx_resize when entering vga mode When entering vga mode the display size likely changes, notify all displaychangelisteners about this. Probably went unnoticed for a while as one if the first things the guest does after leaving qxl native mode and entering qxl vga mode is to set the vga video mode. But there is still a small window where qemu can operate on stale data, leading to crashes now and then. https://bugzilla.redhat.com/show_bug.cgi?id=865767 Signed-off-by: Gerd Hoffmann --- diff --git a/hw/qxl.c b/hw/qxl.c index 063970dc2..e7bf3a11a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1069,7 +1069,7 @@ static void qxl_enter_vga_mode(PCIQXLDevice *d) trace_qxl_enter_vga_mode(d->id); qemu_spice_create_host_primary(&d->ssd); d->mode = QXL_MODE_VGA; - memset(&d->ssd.dirty, 0, sizeof(d->ssd.dirty)); + dpy_gfx_resize(d->ssd.ds); vga_dirty_log_start(&d->vga); }