From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Tue, 23 May 2017 18:06:42 +0000 (+0100)
Subject: ts-examine-logs-save: Do not do readdir $! check
X-Git-Tag: openstack-v11~35
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e131cdd9d078e2af9eb23b37cf1a9d13c5bccf85;p=people%2Faperard%2Fosstest.git

ts-examine-logs-save: Do not do readdir $! check

In perl 5.14 in Massachusetts, this produces this message
  /home/logs/logs/109694/test-amd64-amd64-examine Bad file descriptor at ./ts-examine-logs-save line 100.

Sadly this means there is no way to tell failure apart from end of
directory.  This patch should be reverted when we have a fixed version
of perl.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---

diff --git a/ts-examine-logs-save b/ts-examine-logs-save
index 014522a7..b9c9941c 100755
--- a/ts-examine-logs-save
+++ b/ts-examine-logs-save
@@ -97,7 +97,7 @@ sub save_logs () {
 	logm("saving $f");
 	link "$stash/$f", "$td/$f" or die "$stash $td $f $!";
     }
-    die "$stash $!" if $!;
+    # die "$stash $!" if $!;
     closedir D;
 }