From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 5 Mar 2019 12:21:39 +0000 (+0100)
Subject: conf: Remove impossible error in virDomainDefFormatFeatures
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e0b3e4e11c0e14d90c1b94707abd85741cca7f17;p=libvirt.git

conf: Remove impossible error in virDomainDefFormatFeatures

'i' is always in range of the enum, thus the name is always populated by
virDomainFeatureTypeToString.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9ed153a71f..52022aed0b 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -27765,12 +27765,6 @@ virDomainDefFormatFeatures(virBufferPtr buf,
         const char *name = virDomainFeatureTypeToString(i);
         size_t j;
 
-        if (!name) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("unexpected feature %zu"), i);
-            goto error;
-        }
-
         switch ((virDomainFeature) i) {
         case VIR_DOMAIN_FEATURE_ACPI:
         case VIR_DOMAIN_FEATURE_PAE: