From: Osier Yang Date: Mon, 22 Oct 2012 14:28:59 +0000 (+0800) Subject: virsh: Fix segfault of snapshot-list X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=e0ad4669834d44763f7201ae97b997e9c64e8940;p=libvirt.git virsh: Fix segfault of snapshot-list 'snaps' is used after free()'ed. --- diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index b82837116e..53de2b3add 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -866,7 +866,7 @@ vshSnapshotListCollect(vshControl *ctl, virDomainPtr dom, goto cleanup; } if (from) { - snaps[snaplist->nsnaps++] = from; + snaplist->snaps[snaplist->nsnaps++].snap = from; virDomainSnapshotRef(from); } }