From: Jan Beulich <jbeulich@suse.com>
Date: Mon, 5 Dec 2022 12:40:23 +0000 (+0100)
Subject: CODING_STYLE: explicitly call out label indentation
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ded355eaa4e20cd3dfd22d51332451b110d8c954;p=people%2Fdwmw2%2Fxen.git

CODING_STYLE: explicitly call out label indentation

Since the behavior of "diff -p" to use an unindented label as context
identifier often makes it harder to review patches, make explicit the
requirement for labels to be indented.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
---

diff --git a/CODING_STYLE b/CODING_STYLE
index 5faf274b3a..7d75debcbf 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -47,6 +47,10 @@ void fun(void)
     }
 }
 
+Due to the behavior of GNU diffutils "diff -p", labels should be
+indented by at least one blank.  Non-case labels inside switch() bodies
+are preferred to be indented the same as the block's case labels.
+
 White space
 -----------