From: Michal Privoznik Date: Sat, 27 Jun 2020 07:09:39 +0000 (+0200) Subject: domain_conf: Remove zPCI validation from formatter X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=db4b24b6926a110b09e43a69f1ce489f03f6d44f;p=libvirt.git domain_conf: Remove zPCI validation from formatter In 076591009ad a validation code was added to virDomainDeviceInfoFormat() which reports an error if zPCI address entered in was incomplete. But, there are two problems with this approach. The first problem is the placement of the code - it doesn't belong into XML formatter rather than XML validator. The second one is that at the point of formatting XML the post parse callback has run and thus filled in required info. Therefore this check can never do something useful and instead of moving it into validator, it's removed completely. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 33f177b16f..0c883cd834 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7523,10 +7523,6 @@ virDomainDeviceInfoFormat(virBufferPtr buf, } if (virZPCIDeviceAddressIsPresent(&info->addr.pci.zpci)) { - if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci)) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Missing uid or fid attribute of zPCI address")); - virBufferAsprintf(&childBuf, "\n", info->addr.pci.zpci.uid.value,