From: Paul Durrant <paul.durrant@citrix.com>
Date: Mon, 6 Aug 2018 09:47:58 +0000 (+0100)
Subject: Remove bogus ASSERTion
X-Git-Tag: 9.0.0-rc1~33
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=da62990b8b1a133096c4fc0689b4c15e4e03f64c;p=pvdrivers%2Fwin%2Fxenvbd.git

Remove bogus ASSERTion

In a checked build the code in BlkifRingSchedule() sometimes hits the
ASSERTion:

ASSERT3U(State->Count, ==, 0);

This check is there because this code was ported across from XENVIF. In
the context of that driver the check is valid because it should never be
possible to post a partial sequence of netif requests (since that would
violate the protocol). However, in the context of XENVBD posting blkif
requests, it is perfectly reasonable for a subset of blkif requests for
a single SRB to be posted, and hence __BlkifRingPostRequests() may exit
before State->Count falls to zero. Thus the ASSERTion is invalid in this
context and needs to be removed.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---

diff --git a/src/xenvbd/ring.c b/src/xenvbd/ring.c
index 2f5c876..d595226 100644
--- a/src/xenvbd/ring.c
+++ b/src/xenvbd/ring.c
@@ -1419,8 +1419,6 @@ BlkifRingSchedule(
             RING_SIZE(&BlkifRing->Front) / 4)
             __BlkifRingPushRequests(BlkifRing);
 
-        ASSERT3U(State->Count, == , 0);
-
         if (IsListEmpty(&BlkifRing->SrbQueue))
             break;