From: Peter Maydell Date: Mon, 17 Mar 2014 16:00:33 +0000 (+0000) Subject: hw/i386/acpi_build.c: Avoid shifting left into sign bit X-Git-Tag: qemu-xen-4.5.0-rc1~72^2~10 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d9631b90da6ac592ea76b41a654dd5d29b2645d4;p=qemu-upstream-4.5-testing.git hw/i386/acpi_build.c: Avoid shifting left into sign bit Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 7597517b9..b34d9272d 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -907,7 +907,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) build_append_byte(notify, 0x7B); /* AndOp */ build_append_byte(notify, 0x68); /* Arg0Op */ - build_append_int(notify, 0x1 << i); + build_append_int(notify, 0x1U << i); build_append_byte(notify, 0x00); /* NullName */ build_append_byte(notify, 0x86); /* NotifyOp */ build_append_nameseg(notify, "S%.02X_", PCI_DEVFN(i, 0));