From: Peter Krempa Date: Wed, 23 Sep 2015 12:19:06 +0000 (+0200) Subject: qemu: Refresh memory size only on fresh starts X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d7a0386e229176ec67531aac1412b8a98914da8e;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git qemu: Refresh memory size only on fresh starts Qemu unfortunately doesn't update internal state right after migration and so the actual balloon size as returned by 'query-balloon' are invalid for a while after the CPUs are started after migration. If we'd refresh our internal state at this point we would report invalid current memory size until the next balloon event would arrive. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1242940 --- diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7187dc161..b961f400a 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5023,7 +5023,8 @@ int qemuProcessStart(virConnectPtr conn, /* Since CPUs were not started yet, the balloon could not return the memory * to the host and thus cur_balloon needs to be updated so that GetXMLdesc * and friends return the correct size in case they can't grab the job */ - if (qemuProcessRefreshBalloonState(driver, vm, asyncJob) < 0) + if (!migrateFrom && !snapshot && + qemuProcessRefreshBalloonState(driver, vm, asyncJob) < 0) goto cleanup; VIR_DEBUG("Detecting actual memory size for video device");