From: Michal Privoznik <mprivozn@redhat.com>
Date: Fri, 25 Mar 2016 09:18:00 +0000 (+0100)
Subject: admin_server: Avoid accessing unallocated memory
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d715bfac08aa7b062d3010442637c9e63e7ab91e;p=libvirt.git

admin_server: Avoid accessing unallocated memory

In 68b726b93c11cc90 we tried to fix a mem leak. However, it
wasn't done quite well. Problem is, virNetDaemonGetServers() may
fail in which case virObjectListFreeCount() would be called with
-1 objects to free. But the number of elements is taken in
unsigned rather than signed integer.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/daemon/admin_server.c b/daemon/admin_server.c
index 85cec4627c..1d30ea5079 100644
--- a/daemon/admin_server.c
+++ b/daemon/admin_server.c
@@ -54,7 +54,8 @@ adminConnectListServers(virNetDaemonPtr dmn,
         srvs = NULL;
     }
  cleanup:
-    virObjectListFreeCount(srvs, ret);
+    if (ret > 0)
+        virObjectListFreeCount(srvs, ret);
     return ret;
 }