From: John Ferlan <jferlan@redhat.com>
Date: Tue, 12 Nov 2019 21:10:12 +0000 (-0500)
Subject: util: Remove unnecessary check in virFileRewrite
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d70024d0a6c679433c6e7a4d90a8fe7ada6c0743;p=libvirt.git

util: Remove unnecessary check in virFileRewrite

Since g_strdup_printf will abort, we know @newfile won't be NULL.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---

diff --git a/src/util/virfile.c b/src/util/virfile.c
index cb6cfc0fe7..fca7ff9d35 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -543,8 +543,7 @@ virFileRewrite(const char *path,
 
  cleanup:
     VIR_FORCE_CLOSE(fd);
-    if (newfile)
-        unlink(newfile);
+    unlink(newfile);
     return ret;
 }