From: Ryota Ozaki <ozaki.ryota@gmail.com>
Date: Fri, 14 May 2010 10:08:59 +0000 (+0900)
Subject: Fix a misuse of virAsprintf in qemudDomainMemoryPeek
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d6644013d2c2afc4e1b00cb49ac11ce68d3aac51;p=libvirt.git

Fix a misuse of virAsprintf in qemudDomainMemoryPeek

The code specifies driver->cacheDir as the format string,
but it usually doesn't contain '%s', so the subsequent
argument, "/qemu.mem.XXXXXX", is always ignored.

The patch fixes the misuse.
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index d6a34564f0..0b297fd8b1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9177,7 +9177,7 @@ qemudDomainMemoryPeek (virDomainPtr dom,
         goto endjob;
     }
 
-    if (virAsprintf(&tmp, driver->cacheDir,  "/qemu.mem.XXXXXX") < 0) {
+    if (virAsprintf(&tmp, "%s/qemu.mem.XXXXXX", driver->cacheDir) < 0) {
         virReportOOMError();
         goto endjob;
     }