From: John Ferlan <jferlan@redhat.com>
Date: Fri, 2 Dec 2016 19:58:23 +0000 (-0500)
Subject: storage: Fix type PLOOP type check for storageVolUpload
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d3bba707719d2658e60b574632060b6766fab248;p=libvirt.git

storage: Fix type PLOOP type check for storageVolUpload

Commit id '03e750f3' added support for checking the PLOOP type; however,
it used 'target.type' which no storage code ever fills in, so it will
never be set.  Change to just vol->type (could use vol->target.format
as well).
---

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index df6580781d..a79acc6f06 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -2427,7 +2427,7 @@ storageVolUpload(virStorageVolPtr obj,
     if (VIR_ALLOC(cbdata) < 0 ||
         VIR_STRDUP(cbdata->pool_name, pool->def->name) < 0)
         goto cleanup;
-    if (vol->target.type == VIR_STORAGE_VOL_PLOOP &&
+    if (vol->type == VIR_STORAGE_VOL_PLOOP &&
         VIR_STRDUP(cbdata->vol_path, vol->target.path) < 0)
         goto cleanup;