From: Laine Stump <laine@redhat.com>
Date: Sat, 4 Jul 2020 21:45:57 +0000 (-0400)
Subject: qemu: remove unnecessary virBufferFreeAndReset() after virCommandAddArgBuffer()
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d30cfe70ef32960756b426dac01b592791f49a2f;p=libvirt.git

qemu: remove unnecessary virBufferFreeAndReset() after virCommandAddArgBuffer()

The latter function is guaranteed to always clear out the virBuffer
anyway, so this is redundant and could add to extra cargo-cult code if
used as an example.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f86f32639d..6dbaf40f1e 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -9080,7 +9080,6 @@ qemuBuldDomainLoaderPflashCommandLine(virCommandPtr cmd,
     virCommandAddArgBuffer(cmd, &buf);
 
     if (loader->nvram) {
-        virBufferFreeAndReset(&buf);
         virBufferAddLit(&buf, "file=");
         virQEMUBuildBufferEscapeComma(&buf, loader->nvram);
         virBufferAsprintf(&buf, ",if=pflash,format=raw,unit=%d", unit);