From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 7 Sep 2023 14:22:43 +0000 (+0200)
Subject: qemu: virtiofs: do not force UID 0
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d27b6e5f49b8a5b24086f60fa22752431c50f9c2;p=libvirt.git

qemu: virtiofs: do not force UID 0

Remove the explicit setting of uid 0 when running virtiofsd.

It is not required for privileged mode, where virtiofsd will be run
as root anyway. And for unprivileged mode, virtiofsd no longer requires
to be run as root.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
index af51d58673..4dacd37a1c 100644
--- a/src/qemu/qemu_virtiofs.c
+++ b/src/qemu/qemu_virtiofs.c
@@ -257,10 +257,6 @@ qemuVirtioFSStart(virQEMUDriver *driver,
     if (!(cmd = qemuVirtioFSBuildCommandLine(cfg, fs, &fd)))
         goto error;
 
-    /* so far only running as root is supported */
-    virCommandSetUID(cmd, 0);
-    virCommandSetGID(cmd, 0);
-
     virCommandSetPidFile(cmd, pidfile);
     virCommandSetOutputFD(cmd, &logfd);
     virCommandSetErrorFD(cmd, &logfd);