From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 28 May 2014 09:16:57 +0000 (+0200)
Subject: block: Plug memory leak on brv_open_image() error path
X-Git-Tag: qemu-xen-4.5.0-rc1^2~57
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=d1567e298094a496ad5dc81c9a360dfab98a214d;p=qemu-upstream-4.5-testing.git

block: Plug memory leak on brv_open_image() error path

Introduced in commit da557a.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit b20e61e0d52eef57cf5db55087b16e0b5207e730)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/block.c b/block.c
index e3ba203d9..544843014 100644
--- a/block.c
+++ b/block.c
@@ -1158,6 +1158,7 @@ int bdrv_open_image(BlockDriverState **pbs, const char *filename,
                        bdref_key);
             ret = -EINVAL;
         }
+        QDECREF(image_options);
         goto done;
     }