From: Ioan-Teodor Teugea Date: Wed, 19 Apr 2023 11:29:10 +0000 (+0300) Subject: lib/posix-process: remove clone3 syscall X-Git-Tag: RELEASE-0.13.0~95 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=cee6ce09d720;p=unikraft%2Funikraft.git lib/posix-process: remove clone3 syscall As clone3 currently does not work, and glibc falls back to clone if clone3 is not available (tested on 2.35), the syscall can be removed until a working implementation is available. Signed-off-by: Ioan-Teodor Teugea Reviewed-by: Florin Postolache Reviewed-by: Simon Kuenzer Approved-by: Simon Kuenzer Tested-by: Unikraft CI GitHub-Closes: #847 --- diff --git a/lib/posix-process/Makefile.uk b/lib/posix-process/Makefile.uk index 6139b7059..7a1dbbd52 100644 --- a/lib/posix-process/Makefile.uk +++ b/lib/posix-process/Makefile.uk @@ -17,7 +17,6 @@ LIBPOSIX_PROCESS_SRCS-$(CONFIG_LIBPOSIX_PROCESS_CLONE) += $(LIBPOSIX_PROCESS_BAS COMPFLAGS-$(CONFIG_LIBPOSIX_PROCESS_PIDS) += -fno-builtin-exit -fno-builtin-exit-group UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS_CLONE) += clone-5 -UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS_CLONE) += clone3-2 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS) += execve-3 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS) += wait4-4 waitid-4 UK_PROVIDED_SYSCALLS-$(CONFIG_LIBPOSIX_PROCESS) += getpgid-1 diff --git a/lib/posix-process/clone.c b/lib/posix-process/clone.c index d9ae00840..56a14e775 100644 --- a/lib/posix-process/clone.c +++ b/lib/posix-process/clone.c @@ -528,14 +528,6 @@ int clone(int (*fn)(void *) __unused, void *sp __unused, } #endif /* UK_LIBC_SYSCALLS */ -/* NOTE: There are currently no libc wrapper for clone3 */ -UK_LLSYSCALL_R_DEFINE(long, clone3, - struct clone_args *, cl_args, - size_t, cl_args_len) -{ - return _clone(cl_args, cl_args_len, uk_syscall_return_addr()); -} - /* * Checks that the CLONE_VM is set so that we make sure that * the address space is shared. Unikraft does currently not support