From: YAMANE Toshiaki Date: Mon, 29 Oct 2012 11:05:43 +0000 (+0900) Subject: UPSTREAM: staging/gdm72xx: Use dev_ printks in gdm_usb.c X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=ce71b85435915333eb5d303ae3dce3ade4e05381;p=people%2Faperard%2Flinux-chromebook.git UPSTREAM: staging/gdm72xx: Use dev_ printks in gdm_usb.c fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: YAMANE Toshiaki Signed-off-by: Greg Kroah-Hartman (cherry picked from commit a7d46832df45a41e880ea39ccd4882d012a589bb) Change-Id: Ia854c90ac61c142fea7526a1e3f30a49e230528d Signed-off-by: Ben Chan Reviewed-on: https://gerrit.chromium.org/gerrit/38960 Reviewed-by: Olof Johansson --- diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c index 140975394e8e6..4426941b94706 100644 --- a/drivers/staging/gdm72xx/gdm_usb.c +++ b/drivers/staging/gdm72xx/gdm_usb.c @@ -319,7 +319,7 @@ static int gdm_usb_send(void *priv_dev, void *data, int len, unsigned long flags, flags2; if (!udev->usbdev) { - printk(KERN_ERR "%s: No such device\n", __func__); + dev_err(&usbdev->dev, "%s: No such device\n", __func__); return -ENODEV; } @@ -501,7 +501,7 @@ static int gdm_usb_receive(void *priv_dev, unsigned long flags; if (!udev->usbdev) { - printk(KERN_ERR "%s: No such device\n", __func__); + dev_err(&usbdev->dev, "%s: No such device\n", __func__); return -ENODEV; } @@ -576,9 +576,9 @@ static int gdm_usb_probe(struct usb_interface *intf, idProduct = L2H(usbdev->descriptor.idProduct); bcdDevice = L2H(usbdev->descriptor.bcdDevice); - printk(KERN_INFO "Found GDM USB VID = 0x%04x PID = 0x%04x...\n", - idVendor, idProduct); - printk(KERN_INFO "GCT WiMax driver version %s\n", DRIVER_VERSION); + dev_info(&intf->dev, "Found GDM USB VID = 0x%04x PID = 0x%04x...\n", + idVendor, idProduct); + dev_info(&intf->dev, "GCT WiMax driver version %s\n", DRIVER_VERSION); if (idProduct == EMERGENCY_PID) {