From: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Date: Mon, 12 Dec 2016 09:13:44 +0000 (+0300)
Subject: qemu: agent: take monitor lock in qemuAgentNotifyEvent
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=cdd6819318ac75fbcb24ef7a8d1e6e4643c649eb;p=libvirt.git

qemu: agent: take monitor lock in qemuAgentNotifyEvent

qemuAgentNotifyEvent accesses monitor structure and is called on qemu
reset/shutdown/suspend events under domain lock. Other monitor
functions on the other hand take monitor lock and don't hold domain lock.
Thus it is possible to have risky simultaneous access to the structure
from 2 threads. Let's take monitor lock here to make access exclusive.
---

diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index c50f7604fb..46cad5366f 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -1248,6 +1248,8 @@ qemuAgentMakeStringsArray(const char **strings, unsigned int len)
 void qemuAgentNotifyEvent(qemuAgentPtr mon,
                           qemuAgentEvent event)
 {
+    virObjectLock(mon);
+
     VIR_DEBUG("mon=%p event=%d await_event=%d", mon, event, mon->await_event);
     if (mon->await_event == event) {
         mon->await_event = QEMU_AGENT_EVENT_NONE;
@@ -1257,6 +1259,8 @@ void qemuAgentNotifyEvent(qemuAgentPtr mon,
             virCondSignal(&mon->notify);
         }
     }
+
+    virObjectUnlock(mon);
 }
 
 VIR_ENUM_DECL(qemuAgentShutdownMode);