From: Ján Tomko Date: Mon, 15 Feb 2016 08:04:58 +0000 (+0100) Subject: Revert "storageVolCreateXMLFrom: Check if backend knows how to createVol" X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=cdb757c970a42c0f3c56f6a5e2ec8c22f30c99b4;p=libvirt.git Revert "storageVolCreateXMLFrom: Check if backend knows how to createVol" This reverts commit 611a278fa46d3136b7fe5c6ab05e660ca3c8fdf4. According to the original commit message, this is dead code: It is highly unlikely that a backend will know how to create a volume from a different volume (buildVolFrom) and not know how to create an empty volume (createVol). --- diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 81b158497d..e0ded01619 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -2037,13 +2037,6 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, if (newvol->target.capacity < origvol->target.capacity) newvol->target.capacity = origvol->target.capacity; - if (!backend->createVol) { - virReportError(VIR_ERR_NO_SUPPORT, - "%s", _("storage pool does not support volume " - "creation")); - goto cleanup; - } - if (!backend->buildVolFrom) { virReportError(VIR_ERR_NO_SUPPORT, "%s", _("storage pool does not support"