From: Fam Zheng Date: Thu, 10 Apr 2014 01:33:55 +0000 (+0800) Subject: iscsi: Remember to set ret for iscsi_open in error case X-Git-Tag: qemu-xen-4.5.0-rc1~34^2~1 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=cd82b6fb4daf87f17742f7971ba6cb90d23e6703;p=qemu-upstream-4.5-testing.git iscsi: Remember to set ret for iscsi_open in error case Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- diff --git a/block/iscsi.c b/block/iscsi.c index 64a509f8f..f425573df 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1233,6 +1233,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, iscsi_readcapacity_sync(iscsilun, &local_err); if (local_err != NULL) { error_propagate(errp, local_err); + ret = -EINVAL; goto out; } bs->total_sectors = sector_lun2qemu(iscsilun->num_blocks, iscsilun);